[PR #909] [CLOSED] feat: allow uppercase usernames #562

New Issue

OVERLORD · 2025-10-09T16:52:46+03:00

OVERLORD commented

2025-10-09 16:52:46 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/909
Author: @Felitendo
Created: 9/3/2025
Status: ❌ Closed

Base: main ← Head: feat/uppercase-usernames

📝 Commits (7)

e80abfb feat: allow uppercase usernames
7aaaf17 feat: added translations and tests
9dfdcdf feat: removed toggle and addressed all other concerns
ee8d9a2 fix: username matching logic to handle case-insensitive duplicates
2b96c85 Merge branch 'main' into feat/uppercase-usernames
487c343 Merge branch 'main' into feat/uppercase-usernames
bec9bf9 fix: cleaned up backend mess

📊 Changes

27 files changed (+71 additions, -67 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 backend/internal/cmds/one_time_access_token.go (+3 -2)
📝 backend/internal/middleware/error_handler.go (+1 -1)
📝 backend/internal/service/ldap_service.go (+2 -2)
📝 backend/internal/service/user_service.go (+1 -0)
📝 frontend/messages/cs.json (+1 -1)
📝 frontend/messages/da.json (+1 -1)
📝 frontend/messages/de.json (+1 -1)
📝 frontend/messages/en.json (+1 -1)
📝 frontend/messages/es.json (+1 -1)
📝 frontend/messages/fr.json (+1 -1)
📝 frontend/messages/it.json (+2 -2)
📝 frontend/messages/ko.json (+1 -1)
📝 frontend/messages/nl.json (+2 -2)
📝 frontend/messages/pl.json (+1 -1)
📝 frontend/messages/pt-BR.json (+1 -1)
📝 frontend/messages/ru.json (+1 -1)
📝 frontend/messages/uk.json (+2 -2)
📝 frontend/messages/vi.json (+2 -2)
📝 frontend/messages/zh-CN.json (+1 -1)

...and 7 more files

📄 Description

Allows the use of uppercase usernames like described in this issue: #906

This PR Adds a new toggle to the Administration Settings called "Allow uppercase usernames". When toggling it, it becomes possible to add/update usernames even when they start with an uppercase letter.

This option is disabled by default.

Also sorry for editing the .gitignore file, but i think it will be better to ignore .pnpm-store/ files anyways
fixes #906

TODO:

update toggle name to "Allow Uppercase Usernames" to better fit the styling of the other toggles
add translations
add tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/909 **Author:** [@Felitendo](https://github.com/Felitendo) **Created:** 9/3/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/uppercase-usernames` --- ### 📝 Commits (7) - [`e80abfb`](https://github.com/pocket-id/pocket-id/commit/e80abfb2ccb86b8c37fef3000adbb8bbdcdc480f) feat: allow uppercase usernames - [`7aaaf17`](https://github.com/pocket-id/pocket-id/commit/7aaaf17bd67ee91da21b8bc1bc58ba23bf63cb96) feat: added translations and tests - [`9dfdcdf`](https://github.com/pocket-id/pocket-id/commit/9dfdcdf3d35a58664ab66711acad5cff83c98b2a) feat: removed toggle and addressed all other concerns - [`ee8d9a2`](https://github.com/pocket-id/pocket-id/commit/ee8d9a276ddd2ce876855b89f2ae8aaa78936abc) fix: username matching logic to handle case-insensitive duplicates - [`2b96c85`](https://github.com/pocket-id/pocket-id/commit/2b96c850923278fd100df0c5890cfa4b613e18a4) Merge branch 'main' into feat/uppercase-usernames - [`487c343`](https://github.com/pocket-id/pocket-id/commit/487c3433eda55d79f85d3d29b9cad7504fe7c323) Merge branch 'main' into feat/uppercase-usernames - [`bec9bf9`](https://github.com/pocket-id/pocket-id/commit/bec9bf94c046724eff8f502a29e2ba3ad01ee34f) fix: cleaned up backend mess ### 📊 Changes **27 files changed** (+71 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `backend/internal/cmds/one_time_access_token.go` (+3 -2) 📝 `backend/internal/middleware/error_handler.go` (+1 -1) 📝 `backend/internal/service/ldap_service.go` (+2 -2) 📝 `backend/internal/service/user_service.go` (+1 -0) 📝 `frontend/messages/cs.json` (+1 -1) 📝 `frontend/messages/da.json` (+1 -1) 📝 `frontend/messages/de.json` (+1 -1) 📝 `frontend/messages/en.json` (+1 -1) 📝 `frontend/messages/es.json` (+1 -1) 📝 `frontend/messages/fr.json` (+1 -1) 📝 `frontend/messages/it.json` (+2 -2) 📝 `frontend/messages/ko.json` (+1 -1) 📝 `frontend/messages/nl.json` (+2 -2) 📝 `frontend/messages/pl.json` (+1 -1) 📝 `frontend/messages/pt-BR.json` (+1 -1) 📝 `frontend/messages/ru.json` (+1 -1) 📝 `frontend/messages/uk.json` (+2 -2) 📝 `frontend/messages/vi.json` (+2 -2) 📝 `frontend/messages/zh-CN.json` (+1 -1) _...and 7 more files_ </details> ### 📄 Description Allows the use of uppercase usernames like described in this issue: #906 This PR Adds a new toggle to the Administration Settings called "Allow uppercase usernames". When toggling it, it becomes possible to add/update usernames even when they start with an uppercase letter. <img width="1920" height="917" alt="image" src="https://github.com/user-attachments/assets/a76354fa-098d-4c69-9e0e-e5c8c8e50bee" /> This option is disabled by default. Also sorry for editing the .gitignore file, but i think it will be better to ignore .pnpm-store/ files anyways fixes #906 TODO: - [x] update toggle name to "Allow Uppercase Usernames" to better fit the styling of the other toggles - [x] add translations - [x] add tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 16:52:46 +03:00

OVERLORD closed this issue

2025-10-09 16:52:47 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#562