[PR #970] feat: table and pagination improvements #543

New Issue

OVERLORD · 2025-10-09T16:52:23+03:00

OVERLORD commented

2025-10-09 16:52:23 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/970
Author: @kmendell
Created: 9/21/2025
Status: 🔄 Open

Base: main ← Head: feat/kyles-pagination-attempt

📝 Commits (10+)

3e53508 feat: pagination and table improvements (kyles version)
d388a89 fix facet filters for user status
2250900 finish user table filters
493f5dd Merge branch 'main' into feat/kyles-pagination-attempt
b42731c migrate oidc client and user group tables
1adf8fa migrate audit log table
87b82a6 Merge branch 'main' into feat/kyles-pagination-attempt
4d57792 initial idea for backend filtering
b1c171f get filter logic working for isAdmin
ea6489c cleanup linter

📊 Changes

30 files changed (+1814 additions, -355 deletions)

View changed files

📝 backend/internal/controller/user_controller.go (+1 -1)
📝 backend/internal/model/user.go (+2 -2)
📝 backend/internal/service/user_service.go (+21 -2)
📝 backend/internal/utils/paging_util.go (+123 -3)
📝 frontend/messages/en.json (+14 -1)
📝 frontend/package.json (+1 -0)
📝 frontend/src/lib/components/audit-log-list.svelte (+56 -42)
➕ frontend/src/lib/components/pocket-id-table/data.ts (+29 -0)
➕ frontend/src/lib/components/pocket-id-table/index.ts (+4 -0)
➕ frontend/src/lib/components/pocket-id-table/pocket-id-table-cell.svelte (+9 -0)
➕ frontend/src/lib/components/pocket-id-table/pocket-id-table-checkbox.svelte (+8 -0)
➕ frontend/src/lib/components/pocket-id-table/pocket-id-table-filter.svelte (+130 -0)
➕ frontend/src/lib/components/pocket-id-table/pocket-id-table-toolbar.svelte (+80 -0)
➕ frontend/src/lib/components/pocket-id-table/pocket-id-table-view-options.svelte (+38 -0)
➕ frontend/src/lib/components/pocket-id-table/pocket-id-table.svelte (+594 -0)
➕ frontend/src/lib/components/pocket-id-table/pocket-id-table.types.svelte.ts (+51 -0)
📝 frontend/src/lib/components/signup/signup-token-list-modal.svelte (+68 -66)
➕ frontend/src/lib/components/ui/data-table/data-table.svelte.ts (+141 -0)
➕ frontend/src/lib/components/ui/data-table/flex-render.svelte (+36 -0)
➕ frontend/src/lib/components/ui/data-table/index.ts (+3 -0)

...and 10 more files

📄 Description

My attempt at this, using the tanstack table.

Issues Closed

Fixes: https://github.com/pocket-id/pocket-id/issues/824
Fixes: https://github.com/pocket-id/pocket-id/issues/825

TODO

Migrate Tables to new component
Add filtering logic to backend
parse the page param from the url
refactor table component
refactor backend logic

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/970 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 9/21/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/kyles-pagination-attempt` --- ### 📝 Commits (10+) - [`3e53508`](https://github.com/pocket-id/pocket-id/commit/3e535082a5f96098ec6423d552e28468ebda74db) feat: pagination and table improvements (kyles version) - [`d388a89`](https://github.com/pocket-id/pocket-id/commit/d388a891dc4c377f6447b95a9371cc93a4cfac20) fix facet filters for user status - [`2250900`](https://github.com/pocket-id/pocket-id/commit/2250900a62de19b0080f01882574e1b12c24a271) finish user table filters - [`493f5dd`](https://github.com/pocket-id/pocket-id/commit/493f5dd48c1eb53e5e6674ca3736890af5b72846) Merge branch 'main' into feat/kyles-pagination-attempt - [`b42731c`](https://github.com/pocket-id/pocket-id/commit/b42731c4b6fe0b031210432f334db18e7c3170d0) migrate oidc client and user group tables - [`1adf8fa`](https://github.com/pocket-id/pocket-id/commit/1adf8fa4ca7a6830ba5cf007b4bfa19d8a8eda9e) migrate audit log table - [`87b82a6`](https://github.com/pocket-id/pocket-id/commit/87b82a67041680d7005f8691cec826e7c0bdf271) Merge branch 'main' into feat/kyles-pagination-attempt - [`4d57792`](https://github.com/pocket-id/pocket-id/commit/4d5779291aba62f33385af72f507c3934ee2d4b8) initial idea for backend filtering - [`b1c171f`](https://github.com/pocket-id/pocket-id/commit/b1c171f3f72eb46867b0d797e859f920a14cdcaf) get filter logic working for isAdmin - [`ea6489c`](https://github.com/pocket-id/pocket-id/commit/ea6489cbcf3db1c895829d32ad70d5f4a7e5cbf9) cleanup linter ### 📊 Changes **30 files changed** (+1814 additions, -355 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/controller/user_controller.go` (+1 -1) 📝 `backend/internal/model/user.go` (+2 -2) 📝 `backend/internal/service/user_service.go` (+21 -2) 📝 `backend/internal/utils/paging_util.go` (+123 -3) 📝 `frontend/messages/en.json` (+14 -1) 📝 `frontend/package.json` (+1 -0) 📝 `frontend/src/lib/components/audit-log-list.svelte` (+56 -42) ➕ `frontend/src/lib/components/pocket-id-table/data.ts` (+29 -0) ➕ `frontend/src/lib/components/pocket-id-table/index.ts` (+4 -0) ➕ `frontend/src/lib/components/pocket-id-table/pocket-id-table-cell.svelte` (+9 -0) ➕ `frontend/src/lib/components/pocket-id-table/pocket-id-table-checkbox.svelte` (+8 -0) ➕ `frontend/src/lib/components/pocket-id-table/pocket-id-table-filter.svelte` (+130 -0) ➕ `frontend/src/lib/components/pocket-id-table/pocket-id-table-toolbar.svelte` (+80 -0) ➕ `frontend/src/lib/components/pocket-id-table/pocket-id-table-view-options.svelte` (+38 -0) ➕ `frontend/src/lib/components/pocket-id-table/pocket-id-table.svelte` (+594 -0) ➕ `frontend/src/lib/components/pocket-id-table/pocket-id-table.types.svelte.ts` (+51 -0) 📝 `frontend/src/lib/components/signup/signup-token-list-modal.svelte` (+68 -66) ➕ `frontend/src/lib/components/ui/data-table/data-table.svelte.ts` (+141 -0) ➕ `frontend/src/lib/components/ui/data-table/flex-render.svelte` (+36 -0) ➕ `frontend/src/lib/components/ui/data-table/index.ts` (+3 -0) _...and 10 more files_ </details> ### 📄 Description My attempt at this, using the tanstack table. <details> <summary>Issues Closed</summary> Fixes: https://github.com/pocket-id/pocket-id/issues/824 Fixes: https://github.com/pocket-id/pocket-id/issues/825 </details> TODO - [x] Migrate Tables to new component - [x] Add filtering logic to backend - [x] parse the page param from the url - [ ] refactor table component - [ ] refactor backend logic --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 16:52:23 +03:00

OVERLORD referenced this issue

2025-10-09 16:56:29 +03:00

[PR #543] [MERGED] Update options API for simplewebauthn #751

OVERLORD referenced this issue

2025-10-09 16:56:33 +03:00

[PR #543] Update options API for simplewebauthn #755

Sign in to join this conversation.