starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 13:12:58 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #977] [MERGED] fix: show only country in audit log location if no city instead of Unknown #536

New Issue
Open
opened 2025-10-09 16:52:15 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:52:15 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/977
Author: @vilisseranen
Created: 9/22/2025
Status: ✅ Merged
Merged: 9/24/2025
Merged by: @kmendell

Base: main ← Head: unknown_location_when_no_city

📝 Commits (2)

  • f7eac03 Show only country in audit log location if no city
  • 7fa632f Update audit-log-list.svelte

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 frontend/src/lib/components/audit-log-list.svelte (+9 -3)

📄 Description

Relates to https://github.com/pocket-id/pocket-id/issues/956

When an IP is geolocated but only the country information is available (no city), the UI currently displays the location as unknown. This PR changes this behavior to display the country if it is available but the city is not.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/977 **Author:** [@vilisseranen](https://github.com/vilisseranen) **Created:** 9/22/2025 **Status:** ✅ Merged **Merged:** 9/24/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `unknown_location_when_no_city` --- ### 📝 Commits (2) - [`f7eac03`](https://github.com/pocket-id/pocket-id/commit/f7eac038f3338ad9c9061605d54465042e142003) Show only country in audit log location if no city - [`7fa632f`](https://github.com/pocket-id/pocket-id/commit/7fa632fc74f2c53a4dfe42b3b5cae8a0b7159a12) Update audit-log-list.svelte ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/lib/components/audit-log-list.svelte` (+9 -3) </details> ### 📄 Description Relates to https://github.com/pocket-id/pocket-id/issues/956 When an IP is geolocated but only the country information is available (no city), the UI currently displays the location as unknown. This PR changes this behavior to display the country if it is available but the city is not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:52:15 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#536
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?