mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 14:42:59 +03:00
🚀 Feature: Light/Dark logos for OIDC clients #388
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jloh on GitHub.
Feature description
Hey! Thanks so much for Pocket-ID, I've been playing around with it this morning and love it!
One thing that would be great would be being able to set light/dark logos for the OIDC clients like you can for the main app.
Pitch
My use case is Miniflux just has the letter "M" as the logo and the SVG I'm using is either light or dark so when in dark mode the logo wont work if I have the light logo. Hopefully this makes sense!
Thanks again, love the product.
@stonith404 commented on GitHub:
Thanks for your suggestion.
I think logos like this aren’t very common, so adding them directly would clutter the OIDC form. A simple workaround would be to edit the logo and add a background circle yourself.
@kmendell commented on GitHub:
@stonith404 Do you still agree thats this is out of scope? Or did we want to revisit this?
@mufeedali commented on GitHub:
Logos like this are pretty common. https://simpleicons.org/ for example hosts a lot of icons. If Pocket ID could either recolor it depending on browser light or dark mode, or simply provide a way to set a light and dark icon, that would be the best case scenario. Because this is very nice to look at:
@michaelbeaumont commented on GitHub:
Isn't the fact that Pocket ID itself has both a light and dark logo an indication that this is pretty common? Tailscale, for example, needs this pretty badly for it not to look terrible.