mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 14:42:59 +03:00
🐛 Bug Report: Frontend startup takes a long time without internet connection #319
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nebula-it on GitHub.
Reproduction steps
Restart existing docker container when the host does
It seems like some non async process is trying to reach out to internet and hence failing to startup for a long time.
In similar vein, please add an option to disable the update check as I see the errors logs for that constantly.
Expected behavior
Actual Behavior
Frontend takes a long time to come up, the webUI for pocketID settings does not work when this happens. However the SSO still works.
Version and Environment
v0.36
Log Output
No response
@kmendell commented on GitHub:
My guess is the the issue here is the update check , as i don't think anything else checks out besides that. Unless you are seeing more logs than just those?
@kmendell commented on GitHub:
If the evironment is air gapped, how is the container updating? or how would you know if there is a update? ive never ran stuff (espeically oidc providers) in a air-gapped environment, as external services i use need to access the oidc server.
@stonith404 commented on GitHub:
The update check now times out after two seconds.
@nebula-it commented on GitHub:
@stonith404 Tested and yes it works. Thank you for quick turn around. However, I'd recommend to add an env var
DISABLE_UPDATE_CHECKand if its set to true the update check should not run.@nebula-it commented on GitHub:
In my case, its not exactly air-gapped, just a more locked down environment. PocketID runs in k8s and I have a default deny network policy for all pods/containers, so only allowed traffic is able to get out of the container. And only traffic allowed to container is from the nginx on port 3000 and 8080.
For the update, its done automatically using renovate-bot that updates the image tag and pushes a PR. If that PR is approved argoCD auto deploys the updated version. So app/container itself does not need to check for updates.
Hope that clears it, but feel free to ask if you have anymore questions.
Also, I just wanted to say thanks for such a great project. I was amazed that I could get the SSO stuff setup withing 10mins unlike hours in past.
@stonith404 commented on GitHub:
Yeah I think that would make sense. It should be pretty easy to implement.
@kmendell commented on GitHub:
I created https://github.com/pocket-id/pocket-id/issues/310, just to track this so we dont forget.
@kmendell commented on GitHub:
Ahh okay gotcha, I can see the use case for this, though im going to defer to @stonith404 for the final decsion on it. :)