starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 22:52:58 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

🚀 Feature: Make family/last name optional #263

New Issue
Closed
opened 2025-10-09 16:35:39 +03:00 by OVERLORD · 4 comments
OVERLORD commented 2025-10-09 16:35:39 +03:00
Owner
Copy Link

Originally created by @Sophtli on GitHub.

Originally assigned to: @kmendell on GitHub.

Feature description

The last name in the account details should be optional.

Pitch

As I am only using this application for myself and a few friends, the last name is a bit unnecessary and I would prefer not having to add it.

Originally created by @Sophtli on GitHub. Originally assigned to: @kmendell on GitHub. ### Feature description The last name in the account details should be optional. ### Pitch As I am only using this application for myself and a few friends, the last name is a bit unnecessary and I would prefer not having to add it.
OVERLORD added the feature label 2025-10-09 16:35:39 +03:00
OVERLORD commented 2025-10-09 16:35:42 +03:00
Author
Owner
Copy Link

@Sophtli commented on GitHub:

Thank you for the implementation!
On the "Users" tab I can now successfully remove the last name.

Image

The "My Account" tab still seems to check if the field is empty, though.
I would guess that the following line is the cause:
6004f84845/frontend/src/routes/settings/account/account-form.svelte (L32)

Image

@Sophtli commented on GitHub: Thank you for the implementation! On the "Users" tab I can now successfully remove the last name. ![Image](https://github.com/user-attachments/assets/7a142059-375a-4222-918b-a9f3239d0df6) The "My Account" tab still seems to check if the field is empty, though. I would guess that the following line is the cause: https://github.com/pocket-id/pocket-id/blob/6004f84845c0cc744c9486cfa8d2bf2ffdb92f4e/frontend/src/routes/settings/account/account-form.svelte#L32 ![Image](https://github.com/user-attachments/assets/8460c28b-6a05-47d9-99c1-d03c38e6fdee)
OVERLORD commented 2025-10-09 16:35:42 +03:00
Author
Owner
Copy Link

@kmendell commented on GitHub:

@stonith404 Ill leave this one up to you

@kmendell commented on GitHub: @stonith404 Ill leave this one up to you
OVERLORD commented 2025-10-09 16:35:43 +03:00
Author
Owner
Copy Link

@kmendell commented on GitHub:

This is semi-related to https://github.com/pocket-id/pocket-id/issues/428

@kmendell commented on GitHub: This is semi-related to https://github.com/pocket-id/pocket-id/issues/428
OVERLORD commented 2025-10-09 16:35:44 +03:00
Author
Owner
Copy Link

@kmendell commented on GitHub:

@Sophtli Oops i missed that part ill try to get that fixed here soon.

@kmendell commented on GitHub: @Sophtli Oops i missed that part ill try to get that fixed here soon.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#263
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?