mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 14:42:59 +03:00
🐛 Bug Report: Custom background image lost after update to v1.11.1 #19
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dlhall111 on GitHub.
Reproduction steps
After updating two instances to v1.11.1 (from v1.10.0) both no longer showed their custom background. When I went to re-upload the custom background that operation failed with the following error recorded in the log:
ERR Request with errors: Error #01: remove data/uploads/application-images/background.webp: no such file or directoryIn fact there was not (nor has there ever been for as far as back as I have backups?) a background.webp file in that folder. Upon creating the file manually only then was I able to successfully re-upload my custom background.
Expected behavior
To not lose a custom background as a result of an update (didn't see anything in the release notes about it, apologies if missed) and to not be blocked from uploading a custom background due to a file not existing.
Actual Behavior
Lost custom background, could not re-upload without first manually creating placeholder/default (?) file.
Pocket ID Version
v1.11.1
Database
SQLite
OS and Environment
Pocket ID v1.11.1 running in Docker v28.4.0 on Debian v12 running through Traefik v3.5.2.
Log Output
ERR Request with errors: Error #01: remove data/uploads/application-images/background.webp: no such file or directory@dlhall111 commented on GitHub:
@stonith404 The oldest backup I have is from a week ago but I haven't touched anything in this folder since months back when I first setup Pocket-ID:
@graphixillusion commented on GitHub:
I can confirm that this issue occurrs on my end after 1.11.1 update too...
@Kosette commented on GitHub:
Can confirm this issue after v1.11.1 upgrade.
Manually upload another
webpformat background, everything seems to work fine as always, for old versionsbackground.jpgetc. leftovers can be safely removed manually.@stonith404 commented on GitHub:
Thanks for reporting this.
In
v1.11.0we minified the default background image and switched its format towebp(#933). This change wasn’t included in the release notes because the commit was marked aschore, which the release notes generator ignores (since such changes are usually not relevant to end users).I might have found the the issue. The bug can occur if there are multiple
background.xxximages in theapplication-imagesfolder. Normally this shouldn’t happen, but it could be the result of either a file being added manually to the folder or a bug in a previous Pocket ID version.Since you mentioned having backups, could you share a list of all files inside the
data/uploads/application-imagesfolder from a backup of Pocket IDv1.10.0or earlier? That would help confirm whether this is the issue.@rolikeusch commented on GitHub:
I have (had) the same issue, but I have only one background image in the application-images folder.
I removed all background.xxx files and created a dummy background.webp file, then I was able to add new background image.
@BobWs commented on GitHub:
Yeah same problem after the latest update, renaming the
.jpgfile to.webpworked for me!@graphixillusion commented on GitHub:
I have the same file list in application-images folder
@stonith404 commented on GitHub:
This should be fixed in
v1.11.2.