starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #165] [MERGED] fix: add save changes dialog before sending test email #942

New Issue
Closed
opened 2025-10-08 00:20:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:20:08 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/165
Author: @kmendell
Created: 1/22/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @stonith404

Base: main ← Head: email-save-and-test

📝 Commits (2)

  • 13ee912 fix: add save and test for email setup
  • bb32180 show save changes dialog before sending test email

📊 Changes

1 file changed (+34 additions, -15 deletions)

View changed files

📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-email-form.svelte (+34 -15)

📄 Description

This will fix https://github.com/stonith404/pocket-id/issues/158

Just runs the Save function if the Test Email button is pressed.

Also updated the button to say "Save and Send test email"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/165 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 1/22/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `email-save-and-test` --- ### 📝 Commits (2) - [`13ee912`](https://github.com/pocket-id/pocket-id/commit/13ee9121378627272f3afb5c555dc8fdf6510fa6) fix: add save and test for email setup - [`bb32180`](https://github.com/pocket-id/pocket-id/commit/bb32180134a8ec06cb115f4af837e52f882d4096) show save changes dialog before sending test email ### 📊 Changes **1 file changed** (+34 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-email-form.svelte` (+34 -15) </details> ### 📄 Description This will fix https://github.com/stonith404/pocket-id/issues/158 Just runs the Save function if the Test Email button is pressed. Also updated the button to say "Save and Send test email" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:20:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#942
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?