starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #180] [MERGED] fix: smtp hello for tls connections #935

New Issue
Closed
opened 2025-10-08 00:20:00 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:20:00 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/180
Author: @kmendell
Created: 1/25/2025
Status: ✅ Merged
Merged: 1/27/2025
Merged by: @stonith404

Base: main ← Head: email-hello-tls-fix

📝 Commits (3)

  • 4ae86f4 fix smtp hello for tls connection
  • b738015 Merge branch 'main' into email-hello-tls-fix
  • 8f30829 refactor: move client creation into a separate function

📊 Changes

2 files changed (+56 additions, -28 deletions)

View changed files

📝 backend/internal/service/email_service.go (+55 -27)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-email-form.svelte (+1 -1)

📄 Description

This will fix: https://github.com/stonith404/pocket-id/issues/179#issue-2810943894

The StartTLS function was being called before the Hello function. To fix this i created a helper function and called the Hello function in all the functions that return the client. Tested locally with my postfix relay with TLS and running on Port 587.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/180 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 1/25/2025 **Status:** ✅ Merged **Merged:** 1/27/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `email-hello-tls-fix` --- ### 📝 Commits (3) - [`4ae86f4`](https://github.com/pocket-id/pocket-id/commit/4ae86f4ae84029c1b3f53b01b259f2e99b4d8d77) fix smtp hello for tls connection - [`b738015`](https://github.com/pocket-id/pocket-id/commit/b7380159dd39733bc7d550a6353f6680199a71b6) Merge branch 'main' into email-hello-tls-fix - [`8f30829`](https://github.com/pocket-id/pocket-id/commit/8f30829468c0277d1a487b3edefe8aad48f816a5) refactor: move client creation into a separate function ### 📊 Changes **2 files changed** (+56 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/email_service.go` (+55 -27) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-email-form.svelte` (+1 -1) </details> ### 📄 Description This will fix: https://github.com/stonith404/pocket-id/issues/179#issue-2810943894 The StartTLS function was being called before the Hello function. To fix this i created a helper function and called the Hello function in all the functions that return the client. Tested locally with my postfix relay with TLS and running on Port 587. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:20:01 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#935
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?