starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #236] [MERGED] feat: addition LDAP group membership attributes #910

New Issue
Closed
opened 2025-10-08 00:19:30 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:19:30 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/236
Author: @kmendell
Created: 2/14/2025
Status: ✅ Merged
Merged: 2/16/2025
Merged by: @stonith404

Base: main ← Head: ldap-memberof-attribute

📝 Commits (3)

  • 31c056f feat: addition LDAP group membership attributes
  • 68da4e8 update typo of variable
  • 72baad5 Merge branch 'main' into ldap-memberof-attribute

📊 Changes

6 files changed (+21 additions, -3 deletions)

View changed files

📝 backend/internal/dto/app_config_dto.go (+1 -0)
📝 backend/internal/model/app_config.go (+1 -0)
📝 backend/internal/service/app_config_service.go (+5 -0)
📝 backend/internal/service/ldap_service.go (+3 -2)
📝 frontend/src/lib/types/application-configuration.ts (+1 -0)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte (+10 -1)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/234

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/236 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 2/14/2025 **Status:** ✅ Merged **Merged:** 2/16/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `ldap-memberof-attribute` --- ### 📝 Commits (3) - [`31c056f`](https://github.com/pocket-id/pocket-id/commit/31c056f408a9dcc0ec7b362eb3a00505ea68620a) feat: addition LDAP group membership attributes - [`68da4e8`](https://github.com/pocket-id/pocket-id/commit/68da4e804fb1ab6451d3a8ede5b7412fed1dc7d4) update typo of variable - [`72baad5`](https://github.com/pocket-id/pocket-id/commit/72baad57270035c0f2a08d9b0ca8d2bd3754ff9f) Merge branch 'main' into ldap-memberof-attribute ### 📊 Changes **6 files changed** (+21 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/dto/app_config_dto.go` (+1 -0) 📝 `backend/internal/model/app_config.go` (+1 -0) 📝 `backend/internal/service/app_config_service.go` (+5 -0) 📝 `backend/internal/service/ldap_service.go` (+3 -2) 📝 `frontend/src/lib/types/application-configuration.ts` (+1 -0) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte` (+10 -1) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/234 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:19:30 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#910
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?