mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 23:02:59 +03:00
🚀 Feature: Add display_name to users #91
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Elyviere on GitHub.
Originally assigned to: @kmendell on GitHub.
Feature description
A new field added to the user, "Display Name", which can be used by apps which separate usernames and display_name, and that can be synchronised from LDAP.
Pitch
I'm using the ldap-integration in PocketID, and in my ldap (LLDAP) the field display_name is included by default on users. I'm also using an app, Reitti, which I'm using PocketID OAuth to sign in to. Reitti has a separate field for username and display_name.
So, it stands to reason that I should be able to get my display_name which I've input in lldap and give it to Reitti. However, because PocketID doesn't get the display_name from ldap, it doesn't get included when I sign in to Reitti.
@stonith404 commented on GitHub:
The display name is just the first and last name combined, right? If so, Pocket ID returns a "name" claim which includes the full name.
@Elyviere commented on GitHub:
No, it's a separate field. It's used to decide which name to show other users, as sometimes you don't want to use your username or first name. Here are the user fields in LLDAP:
@stonith404 commented on GitHub:
Okay, thanks for the clarification. I'm marking this as "needs more upvotes" to check if other users want this too.