starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-11 07:42:58 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #325] [MERGED] feat: add OIDC refresh_token support #879

New Issue
Closed
opened 2025-10-08 00:18:56 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:18:56 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/325
Author: @kmendell
Created: 3/13/2025
Status: ✅ Merged
Merged: 3/23/2025
Merged by: @stonith404

Base: main ← Head: feat/refresh-tokens

📝 Commits (10+)

  • 3f7b69e feat: oidc refresh_token
  • e5d272d update api documentation to reflect new response
  • dd93d7d remove unused commented code
  • 317602b add cleanup job for refresh tokens
  • c41ed31 validate client secret for non public clients
  • e3c0d81 Merge branch 'main' into feat/refresh-tokens
  • fb4836b WIP: refresh_token tests
  • 35d4b23 remove unneeded comments
  • f025d04 fix e2e tests
  • bcf69e8 Merge branch 'main' into feat/refresh-tokens

📊 Changes

14 files changed (+333 additions, -49 deletions)

View changed files

📝 backend/internal/common/errors.go (+30 -0)
📝 backend/internal/controller/oidc_controller.go (+44 -9)
📝 backend/internal/controller/well_known_controller.go (+1 -0)
📝 backend/internal/dto/oidc_dto.go (+10 -1)
📝 backend/internal/job/db_cleanup.go (+6 -0)
📝 backend/internal/model/oidc.go (+14 -0)
📝 backend/internal/service/oidc_service.go (+120 -38)
📝 backend/internal/service/test_service.go (+11 -0)
➕ backend/resources/migrations/postgres/20250323184520_oidc_refresh_tokens.down.sql (+2 -0)
➕ backend/resources/migrations/postgres/20250323184520_oidc_refresh_tokens.up.sql (+11 -0)
➕ backend/resources/migrations/sqlite/20250323184520_oidc_refresh_tokens.down.sql (+2 -0)
➕ backend/resources/migrations/sqlite/20250323184520_oidc_refresh_tokens.up.sql (+11 -0)
📝 frontend/tests/data.ts (+13 -0)
📝 frontend/tests/oidc.spec.ts (+58 -1)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/319

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/325 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 3/13/2025 **Status:** ✅ Merged **Merged:** 3/23/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feat/refresh-tokens` --- ### 📝 Commits (10+) - [`3f7b69e`](https://github.com/pocket-id/pocket-id/commit/3f7b69e6b1b9ebc06cfaa15a4a8e0fe92f4f558e) feat: oidc refresh_token - [`e5d272d`](https://github.com/pocket-id/pocket-id/commit/e5d272dc37c58a4913b22ecd8aa8eb92242485de) update api documentation to reflect new response - [`dd93d7d`](https://github.com/pocket-id/pocket-id/commit/dd93d7d7360dbaae59b9528dded6a20c3d603c03) remove unused commented code - [`317602b`](https://github.com/pocket-id/pocket-id/commit/317602b41cbecd6d0f4b9deab8419b780fa4f543) add cleanup job for refresh tokens - [`c41ed31`](https://github.com/pocket-id/pocket-id/commit/c41ed311d854f0a84de267e9f58e843f31fa2c79) validate client secret for non public clients - [`e3c0d81`](https://github.com/pocket-id/pocket-id/commit/e3c0d817ca76b51891f209584c6af0fce7a2bbc4) Merge branch 'main' into feat/refresh-tokens - [`fb4836b`](https://github.com/pocket-id/pocket-id/commit/fb4836b5f35bcd85921555cc70b95c88ad91b930) WIP: refresh_token tests - [`35d4b23`](https://github.com/pocket-id/pocket-id/commit/35d4b2393d66d96b7ce4e3e924d68a31c8635e7e) remove unneeded comments - [`f025d04`](https://github.com/pocket-id/pocket-id/commit/f025d047c99715b71f638013de82b9e454ad5523) fix e2e tests - [`bcf69e8`](https://github.com/pocket-id/pocket-id/commit/bcf69e8eff57b8449852701d37168181aefc1307) Merge branch 'main' into feat/refresh-tokens ### 📊 Changes **14 files changed** (+333 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/errors.go` (+30 -0) 📝 `backend/internal/controller/oidc_controller.go` (+44 -9) 📝 `backend/internal/controller/well_known_controller.go` (+1 -0) 📝 `backend/internal/dto/oidc_dto.go` (+10 -1) 📝 `backend/internal/job/db_cleanup.go` (+6 -0) 📝 `backend/internal/model/oidc.go` (+14 -0) 📝 `backend/internal/service/oidc_service.go` (+120 -38) 📝 `backend/internal/service/test_service.go` (+11 -0) ➕ `backend/resources/migrations/postgres/20250323184520_oidc_refresh_tokens.down.sql` (+2 -0) ➕ `backend/resources/migrations/postgres/20250323184520_oidc_refresh_tokens.up.sql` (+11 -0) ➕ `backend/resources/migrations/sqlite/20250323184520_oidc_refresh_tokens.down.sql` (+2 -0) ➕ `backend/resources/migrations/sqlite/20250323184520_oidc_refresh_tokens.up.sql` (+11 -0) 📝 `frontend/tests/data.ts` (+13 -0) 📝 `frontend/tests/oidc.spec.ts` (+58 -1) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/319 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:18:56 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#879
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?