starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #332] [MERGED] feat(passkeys): name new passkeys based on agguids #873

New Issue
Closed
opened 2025-10-08 00:18:47 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:18:47 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/332
Author: @kmendell
Created: 3/14/2025
Status: ✅ Merged
Merged: 3/20/2025
Merged by: @stonith404

Base: main ← Head: feat/passkey-auth-info

📝 Commits (10+)

  • 359079c feat(passkeys): name new passkeys based on agguids
  • 2f4aa1a add fido mds cache in addition to manual map for aaguids entries are not in the MDS
  • cca1fdc remove userAgent commented code
  • 6fa205c store aaguids.json locally in container, update once a week via github actions
  • c779784 remove un-needed log, and userAgent arguments
  • b6af4b9 Merge branch 'main' into feat/passkey-auth-info
  • 39aaa78 add test file
  • 35563ed add minified to jq command
  • fe45d8b ci/cd: remove install jq from workflow
  • 69451d2 use hex.EncodeToString instead of fmt.Sprintf

📊 Changes

6 files changed (+240 additions, -2 deletions)

View changed files

➕ .github/workflows/update-aaguids.yml (+34 -0)
📝 backend/internal/service/webauthn_service.go (+14 -1)
➕ backend/internal/utils/aaguid_util.go (+64 -0)
➕ backend/internal/utils/aaguid_util_test.go (+126 -0)
➕ backend/resources/aaguids.json (+1 -0)
📝 backend/resources/files.go (+1 -1)

📄 Description

This is a QoL feature, but instead of just "New Passkey" always being the default name, this PR introduces a AAGUID list that will name the passkey according to the aaguid for the password manager, or platform authenticator.

I forked the list i found: https://github.com/kmendell/passkey-authenticator-aaguids/tree/main, there may be a better way to implement the list, but i didn't think we would want to load that big of a json file all at once, so i just picked some common ones.

Another more official list would be the FIDO MDS https://fidoalliance.org/metadata/

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/332 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/20/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feat/passkey-auth-info` --- ### 📝 Commits (10+) - [`359079c`](https://github.com/pocket-id/pocket-id/commit/359079c8bc91f73e7aa20bdda1409d92b2d7af60) feat(passkeys): name new passkeys based on agguids - [`2f4aa1a`](https://github.com/pocket-id/pocket-id/commit/2f4aa1add52c4c132e9c1ab4f152a0f2bdf72167) add fido mds cache in addition to manual map for aaguids entries are not in the MDS - [`cca1fdc`](https://github.com/pocket-id/pocket-id/commit/cca1fdce28990b91496d8fcf3b1f3ef38c89f415) remove userAgent commented code - [`6fa205c`](https://github.com/pocket-id/pocket-id/commit/6fa205cbdbd2a982c1f1930511b093293813587f) store aaguids.json locally in container, update once a week via github actions - [`c779784`](https://github.com/pocket-id/pocket-id/commit/c7797848d8d168ac91aa53a890c8f691e8bfa9b1) remove un-needed log, and userAgent arguments - [`b6af4b9`](https://github.com/pocket-id/pocket-id/commit/b6af4b96d2d21331b8e025e95fd40fa4db4f1ca6) Merge branch 'main' into feat/passkey-auth-info - [`39aaa78`](https://github.com/pocket-id/pocket-id/commit/39aaa78020912d70d19c7f36f54974ae09c7b486) add test file - [`35563ed`](https://github.com/pocket-id/pocket-id/commit/35563ed49b343c6e2f1e1ffec02d81ca827846f3) add minified to jq command - [`fe45d8b`](https://github.com/pocket-id/pocket-id/commit/fe45d8bc1345e23eec912ae87869b2a84e72c1f4) ci/cd: remove install jq from workflow - [`69451d2`](https://github.com/pocket-id/pocket-id/commit/69451d21573bf7646fa12794c240ff9849088bb0) use hex.EncodeToString instead of fmt.Sprintf ### 📊 Changes **6 files changed** (+240 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/update-aaguids.yml` (+34 -0) 📝 `backend/internal/service/webauthn_service.go` (+14 -1) ➕ `backend/internal/utils/aaguid_util.go` (+64 -0) ➕ `backend/internal/utils/aaguid_util_test.go` (+126 -0) ➕ `backend/resources/aaguids.json` (+1 -0) 📝 `backend/resources/files.go` (+1 -1) </details> ### 📄 Description This is a QoL feature, but instead of just "New Passkey" always being the default name, this PR introduces a AAGUID list that will name the passkey according to the aaguid for the password manager, or platform authenticator. I forked the list i found: https://github.com/kmendell/passkey-authenticator-aaguids/tree/main, there may be a better way to implement the list, but i didn't think we would want to load that big of a json file all at once, so i just picked some common ones. Another more official list would be the FIDO MDS https://fidoalliance.org/metadata/ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:18:48 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#873
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?