starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #337] [MERGED] fix: pocket-id notify emails are considered as medium spam by rspamd #872

New Issue
Open
opened 2025-10-08 00:18:47 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:18:47 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/337
Author: @alexlehm
Created: 3/14/2025
Status: ✅ Merged
Merged: 3/16/2025
Merged by: @stonith404

Base: main ← Head: email-headers-missing

📝 Commits (3)

  • 0512303 fixes #330 pocket-id notify emails are considered as medium spam by rspamd
  • 4eb05d5 fix assigned, sorry forgot to commit my last changes
  • 90be99c when the sender email does not have an @, use os.Hostname as fallback

📊 Changes

2 files changed (+30 additions, -1 deletions)

View changed files

📝 backend/internal/service/email_service.go (+25 -0)
📝 backend/internal/utils/email/composer.go (+5 -1)

📄 Description

add additional mail headers and do not encode realnames when they are only 7bit ascii chars

Fixes: #330

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/337 **Author:** [@alexlehm](https://github.com/alexlehm) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/16/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `email-headers-missing` --- ### 📝 Commits (3) - [`0512303`](https://github.com/pocket-id/pocket-id/commit/05123031af41de9cc83b783b62846e7cae39755a) fixes #330 pocket-id notify emails are considered as medium spam by rspamd - [`4eb05d5`](https://github.com/pocket-id/pocket-id/commit/4eb05d5a174d665f0f85563684447ea3a77056cb) fix assigned, sorry forgot to commit my last changes - [`90be99c`](https://github.com/pocket-id/pocket-id/commit/90be99c5517688a3d05082116b2e9748edd704f8) when the sender email does not have an @, use os.Hostname as fallback ### 📊 Changes **2 files changed** (+30 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/email_service.go` (+25 -0) 📝 `backend/internal/utils/email/composer.go` (+5 -1) </details> ### 📄 Description add additional mail headers and do not encode realnames when they are only 7bit ascii chars Fixes: #330 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:18:47 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#872
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?