starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-11 07:42:58 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #392] fix: use transactions when operations involve multiple database queries #845

New Issue
Closed
opened 2025-10-08 00:18:17 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:18:17 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/pocket-id/pocket-id/pull/392

State: closed
Merged: Yes

Currently, the backend does not use database transactions, even when there are operations performed in sequence. For example: 4d049bbe24/backend/internal/service/user_service.go (L166-L194) where the user is loaded from the DB and then updates

This can cause a number of problems if multiple requests happen in parallel, and in some cases could also have security implications.

This PR updates the backend's to add transactions where they are needed.

**Original Pull Request:** https://github.com/pocket-id/pocket-id/pull/392 **State:** closed **Merged:** Yes --- Currently, the backend does not use database transactions, even when there are operations performed in sequence. For example: https://github.dev/pocket-id/pocket-id/blob/4d049bbe24aa0b714c6f97369f1562064076a3b4/backend/internal/service/user_service.go#L166-L194 where the user is loaded from the DB and then updates This can cause a number of problems if multiple requests happen in parallel, and in some cases _could_ also have security implications. This PR updates the backend's to add transactions where they are needed.
OVERLORD added the pull-request label 2025-10-08 00:18:17 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#845
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?