[PR #401] [MERGED] chore(deps): install inlang plugins from npm #836

New Issue

OVERLORD · 2025-10-08T00:18:07+03:00

OVERLORD commented

2025-10-08 00:18:07 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/401
Author: @gepbird
Created: 3/28/2025
Status: ✅ Merged
Merged: 3/30/2025
Merged by: @stonith404

Base: main ← Head: inlang-plugins-npm

📝 Commits (3)

b4abc5b chore(deps): update package-lock.json
e8e70ea chore(deps): install inlang plugins from npm
9bf064e Merge branch 'main' into inlang-plugins-npm

📊 Changes

3 files changed (+89 additions, -4 deletions)

View changed files

📝 frontend/package-lock.json (+85 -2)
📝 frontend/package.json (+2 -0)
📝 frontend/project.inlang/settings.json (+2 -2)

📄 Description

Since https://github.com/pocket-id/pocket-id/pull/349, building the project fetched the inlang plugins at build time (every time you ran npm run build), rather than install time (with npm install), this PR puts inlang plugins at install time.

I'm packaging pocket-id for nixpkgs where more people will be able to use your project. This has caused me a few hours of debugging, as nix ensures reproducibility by cutting off the internet at build time, and there were no error messages coming from inlang that downloading the plugins have failed, only some warnings from vite.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/401 **Author:** [@gepbird](https://github.com/gepbird) **Created:** 3/28/2025 **Status:** ✅ Merged **Merged:** 3/30/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `inlang-plugins-npm` --- ### 📝 Commits (3) - [`b4abc5b`](https://github.com/pocket-id/pocket-id/commit/b4abc5b95428f521d7babdad8faf1ce9d403e59c) chore(deps): update package-lock.json - [`e8e70ea`](https://github.com/pocket-id/pocket-id/commit/e8e70ea564a9035f6e1c609085ec63e7ee4e6eaf) chore(deps): install inlang plugins from npm - [`9bf064e`](https://github.com/pocket-id/pocket-id/commit/9bf064ecc453b062d70efce5aef72517ac0260aa) Merge branch 'main' into inlang-plugins-npm ### 📊 Changes **3 files changed** (+89 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/package-lock.json` (+85 -2) 📝 `frontend/package.json` (+2 -0) 📝 `frontend/project.inlang/settings.json` (+2 -2) </details> ### 📄 Description Since https://github.com/pocket-id/pocket-id/pull/349, building the project fetched the inlang plugins at build time (every time you ran `npm run build`), rather than install time (with `npm install`), this PR puts inlang plugins at install time. I'm packaging pocket-id for nixpkgs where more people will be able to use your project. This has caused me a [few hours of debugging](https://github.com/NixOS/nixpkgs/pull/381867#issuecomment-2746330493), as nix ensures reproducibility by cutting off the internet at build time, and there were no error messages coming from inlang that downloading the plugins have failed, only some warnings from vite. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-08 00:18:07 +03:00

OVERLORD closed this issue

2025-10-08 00:18:09 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#836