[PR #481] [MERGED] refactor: do not force redirects to happen on the server #783

New Issue

OVERLORD · 2025-10-08T00:17:05+03:00

OVERLORD commented

2025-10-08 00:17:05 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/481
Author: @ItalyPaleAle
Created: 4/24/2025
Status: ✅ Merged
Merged: 4/24/2025
Merged by: @stonith404

Base: main ← Head: sveltekit-client-1

📝 Commits (1)

eca7915 Do not force redirects to happen on the server

📊 Changes

10 files changed (+31 additions, -26 deletions)

View changed files

📝 frontend/.prettierignore (+4 -0)
📝 frontend/src/hooks.server.ts (+6 -8)
➖ frontend/src/routes/+page.server.ts (+0 -6)
➕ frontend/src/routes/+page.ts (+6 -0)
📝 frontend/src/routes/lc/+page.ts (+2 -1)
📝 frontend/src/routes/lc/[code]/+page.ts (+2 -1)
📝 frontend/src/routes/login/alternative/code/+page.ts (+2 -2)
➖ frontend/src/routes/login/alternative/email/+page.server.ts (+0 -7)
➕ frontend/src/routes/login/alternative/email/+page.ts (+7 -0)
📝 frontend/src/routes/settings/+page.ts (+2 -1)

📄 Description

Small refactor on the frontend: do not force redirects to happen on the server with +page.server.ts; use +page.ts instead, as they can happen on the client too

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/481 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 4/24/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `sveltekit-client-1` --- ### 📝 Commits (1) - [`eca7915`](https://github.com/pocket-id/pocket-id/commit/eca79159d69216d94502d0189d004812d18dd7d4) Do not force redirects to happen on the server ### 📊 Changes **10 files changed** (+31 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `frontend/.prettierignore` (+4 -0) 📝 `frontend/src/hooks.server.ts` (+6 -8) ➖ `frontend/src/routes/+page.server.ts` (+0 -6) ➕ `frontend/src/routes/+page.ts` (+6 -0) 📝 `frontend/src/routes/lc/+page.ts` (+2 -1) 📝 `frontend/src/routes/lc/[code]/+page.ts` (+2 -1) 📝 `frontend/src/routes/login/alternative/code/+page.ts` (+2 -2) ➖ `frontend/src/routes/login/alternative/email/+page.server.ts` (+0 -7) ➕ `frontend/src/routes/login/alternative/email/+page.ts` (+7 -0) 📝 `frontend/src/routes/settings/+page.ts` (+2 -1) </details> ### 📄 Description Small refactor on the frontend: do not force redirects to happen on the server with `+page.server.ts`; use `+page.ts` instead, as they can happen on the client too --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-08 00:17:05 +03:00

OVERLORD closed this issue

2025-10-08 00:17:07 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#783