starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #483] [CLOSED] fix: ensure to use correct forwarded ip #780

New Issue
Open
opened 2025-10-08 00:17:02 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:17:02 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/483
Author: @kmendell
Created: 4/25/2025
Status: ❌ Closed

Base: main ← Head: fix/use-client-ip

📝 Commits (2)

  • 36e1e64 fix: ensure to use correct forwarded ip
  • 4ad1170 Merge branch 'main' into fix/use-client-ip

📊 Changes

2 files changed (+45 additions, -0 deletions)

View changed files

📝 backend/internal/bootstrap/router_bootstrap.go (+1 -0)
➕ backend/internal/middleware/trust_proxy.go (+44 -0)

📄 Description

GIN doesnt seem to repect the X-Client-IP or Forwarded IP if the built in caddy is not used. This logic does not work yet , but still looking into it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/483 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 4/25/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/use-client-ip` --- ### 📝 Commits (2) - [`36e1e64`](https://github.com/pocket-id/pocket-id/commit/36e1e644d555e18807b47fb98a79e02b41248097) fix: ensure to use correct forwarded ip - [`4ad1170`](https://github.com/pocket-id/pocket-id/commit/4ad1170ffeb8e13bc8bd99d21b614fd26510cb97) Merge branch 'main' into fix/use-client-ip ### 📊 Changes **2 files changed** (+45 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/bootstrap/router_bootstrap.go` (+1 -0) ➕ `backend/internal/middleware/trust_proxy.go` (+44 -0) </details> ### 📄 Description GIN doesnt seem to repect the X-Client-IP or Forwarded IP if the built in caddy is not used. This logic does not work yet , but still looking into it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:17:02 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#780
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?