starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-11 07:42:58 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #487] [MERGED] fix: pass context to methods that were missing it #775

New Issue
Closed
opened 2025-10-08 00:16:56 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:16:56 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/487
Author: @ItalyPaleAle
Created: 4/26/2025
Status: ✅ Merged
Merged: 4/26/2025
Merged by: @kmendell

Base: main ← Head: fix-missing-context

📝 Commits (1)

  • 17cdcc3 fix: pass context to methods that were missing it

📊 Changes

2 files changed (+35 additions, -30 deletions)

View changed files

📝 backend/internal/controller/oidc_controller.go (+20 -22)
📝 backend/internal/service/oidc_service.go (+15 -8)

📄 Description

A few methods that were added recently did not receive the context from the request. This fixes it and ensures consistency.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/487 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 4/26/2025 **Status:** ✅ Merged **Merged:** 4/26/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `fix-missing-context` --- ### 📝 Commits (1) - [`17cdcc3`](https://github.com/pocket-id/pocket-id/commit/17cdcc3ba5f8828f408cc1c8eb7298ecca08fc87) fix: pass context to methods that were missing it ### 📊 Changes **2 files changed** (+35 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/controller/oidc_controller.go` (+20 -22) 📝 `backend/internal/service/oidc_service.go` (+15 -8) </details> ### 📄 Description A few methods that were added recently did not receive the context from the request. This fixes it and ensures consistency. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:16:56 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#775
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?