starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 23:02:59 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #704] [MERGED] fix: token introspection authentication not handled correctly #668

New Issue
Closed
opened 2025-10-08 00:14:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:14:54 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/704
Author: @stonith404
Created: 6/30/2025
Status: ✅ Merged
Merged: 7/2/2025
Merged by: @stonith404

Base: main ← Head: fix/token-introspect-auth

📝 Commits (6)

  • ce0d455 fix: token introspection authentication not handled correctly
  • a7c31d5 use client id from jwt for client assertions
  • 7e1857b fix unit tests
  • 44b1470 disallow token introspection for public clients
  • 30665a6 Merge branch 'main' into fix/token-introspect-auth
  • 75f4e78 fix unit test

📊 Changes

2 files changed (+87 additions, -43 deletions)

View changed files

📝 backend/internal/service/oidc_service.go (+59 -30)
📝 backend/internal/service/oidc_service_test.go (+28 -13)

📄 Description

Fixes #700

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/704 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 6/30/2025 **Status:** ✅ Merged **Merged:** 7/2/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `fix/token-introspect-auth` --- ### 📝 Commits (6) - [`ce0d455`](https://github.com/pocket-id/pocket-id/commit/ce0d4554936a3b8404a089718a48f9236187f349) fix: token introspection authentication not handled correctly - [`a7c31d5`](https://github.com/pocket-id/pocket-id/commit/a7c31d54573a91d7abfd6b843492b453ae481bee) use client id from jwt for client assertions - [`7e1857b`](https://github.com/pocket-id/pocket-id/commit/7e1857b0491c1d278ac2e193d1376ef53ed1c60f) fix unit tests - [`44b1470`](https://github.com/pocket-id/pocket-id/commit/44b14706467923b777606a7f4caf1938d6d9f49f) disallow token introspection for public clients - [`30665a6`](https://github.com/pocket-id/pocket-id/commit/30665a6ff5875b21da08aa8f720bd7556bf48e7b) Merge branch 'main' into fix/token-introspect-auth - [`75f4e78`](https://github.com/pocket-id/pocket-id/commit/75f4e78fae3edf9b1570f3d16acdb0ecb661672a) fix unit test ### 📊 Changes **2 files changed** (+87 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/oidc_service.go` (+59 -30) 📝 `backend/internal/service/oidc_service_test.go` (+28 -13) </details> ### 📄 Description Fixes #700 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:14:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#668
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?