[PR #716] [MERGED] feat: distroless container additional variant + healthcheck command #660

New Issue

OVERLORD · 2025-10-08T00:14:45+03:00

OVERLORD commented

2025-10-08 00:14:45 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/716
Author: @ItalyPaleAle
Created: 7/4/2025
Status: ✅ Merged
Merged: 7/4/2025
Merged by: @ItalyPaleAle

Base: main ← Head: distroless-container

📝 Commits (1)

accd1aa feat: distroless container additional variant + healthcheck command

📊 Changes

9 files changed (+157 additions, -19 deletions)

View changed files

📝 .github/workflows/build-next.yml (+15 -1)
📝 .github/workflows/release.yml (+26 -8)
📝 Dockerfile (+2 -0)
➕ Dockerfile-distroless (+18 -0)
📝 Dockerfile-prebuilt (+3 -1)
📝 backend/internal/bootstrap/bootstrap.go (+1 -5)
➕ backend/internal/cmds/healthcheck.go (+83 -0)
📝 backend/internal/cmds/root.go (+7 -2)
📝 docker-compose.yml (+2 -2)

📄 Description

Fix #680

Adds a -distroless variant for the container image, which is based on gcr.io/distroless/static-debian12:nonroot

Because the distroless image doesn't have curl, in order to perform healthchecks I have added a new sub-command to the pocket-id binary pocket-id healthcheck, which performs a healthcheck on a running instance of Pocket ID. This is a simpler alternative to shipping the curl binary. (Note that curl is still bundled in the non-distroless image, for backwards compatibility)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/716 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 7/4/2025 **Status:** ✅ Merged **Merged:** 7/4/2025 **Merged by:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Base:** `main` ← **Head:** `distroless-container` --- ### 📝 Commits (1) - [`accd1aa`](https://github.com/pocket-id/pocket-id/commit/accd1aa7005fe4f652820f758d124e03e20bd9b6) feat: distroless container additional variant + healthcheck command ### 📊 Changes **9 files changed** (+157 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-next.yml` (+15 -1) 📝 `.github/workflows/release.yml` (+26 -8) 📝 `Dockerfile` (+2 -0) ➕ `Dockerfile-distroless` (+18 -0) 📝 `Dockerfile-prebuilt` (+3 -1) 📝 `backend/internal/bootstrap/bootstrap.go` (+1 -5) ➕ `backend/internal/cmds/healthcheck.go` (+83 -0) 📝 `backend/internal/cmds/root.go` (+7 -2) 📝 `docker-compose.yml` (+2 -2) </details> ### 📄 Description Fix #680 Adds a `-distroless` variant for the container image, which is based on `gcr.io/distroless/static-debian12:nonroot` Because the distroless image doesn't have curl, in order to perform healthchecks I have added a new sub-command to the pocket-id binary `pocket-id healthcheck`, which performs a healthcheck on a running instance of Pocket ID. This is a simpler alternative to shipping the curl binary. (Note that curl is still bundled in the non-distroless image, for backwards compatibility) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-08 00:14:45 +03:00

OVERLORD closed this issue

2025-10-08 00:14:47 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#660