starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #737] fix: login failures on Postgres when IP is null #648

New Issue
Closed
opened 2025-10-08 00:14:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:14:31 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/pocket-id/pocket-id/pull/737

State: closed
Merged: Yes

fixes #686 (for real)

The fix in #695 was not complete. It allowed the entry to be stored in the DB, but still caused failures when reading. This completes the fix.

Also fixes: authenticating with a one-time code did not create a log entry when the IP is empty

**Original Pull Request:** https://github.com/pocket-id/pocket-id/pull/737 **State:** closed **Merged:** Yes --- fixes #686 (for real) The fix in #695 was not complete. It allowed the entry to be stored in the DB, but still caused failures when reading. This completes the fix. Also fixes: authenticating with a one-time code did not create a log entry when the IP is empty
OVERLORD added the pull-request label 2025-10-08 00:14:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#648
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?