starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 23:02:59 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #830] [CLOSED] feat: add ability to set custom client ID #599

New Issue
Closed
opened 2025-10-08 00:13:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:13:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/830
Author: @James18232
Created: 8/13/2025
Status: ❌ Closed

Base: main ← Head: feat-customcredentials

📝 Commits (10+)

📊 Changes

8 files changed (+234 additions, -10 deletions)

View changed files

📝 backend/internal/common/errors.go (+9 -0)
📝 backend/internal/controller/oidc_controller.go (+60 -0)
📝 backend/internal/dto/oidc_dto.go (+8 -0)
📝 backend/internal/model/oidc.go (+5 -0)
📝 backend/internal/service/oidc_service.go (+91 -0)
📝 frontend/src/lib/services/oidc-service.ts (+7 -1)
📝 frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte (+7 -1)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte (+47 -8)

📄 Description

this PR includes changes to support a custom client id/client secret to be used for a client.

This is required for services such as owncloud ocis, who use fixed client id/client secrets for some elements of their services.

I believe this is not strictly in accordance with the oidc specs, so this is proposed as an advanced option only, after a client is setup in the usual manner.

happy for input if things are not quite right - i have done preliminary testing and think it is ok.

fixes #508.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/830 **Author:** [@James18232](https://github.com/James18232) **Created:** 8/13/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat-customcredentials` --- ### 📝 Commits (10+) - [`67b359c`](https://github.com/pocket-id/pocket-id/commit/67b359cb8b94398c7b646e7d4ae89370a72eecc3) Feat: customcredentials (#9) - [`c0bfc48`](https://github.com/pocket-id/pocket-id/commit/c0bfc48f76eb199b6022bc6ba6e4f12a58c92729) fix: faililng checks - [`9eb8463`](https://github.com/pocket-id/pocket-id/commit/9eb84630f2b06935f19a592d6e41fb617e088544) fix: failing checks - [`8583c77`](https://github.com/pocket-id/pocket-id/commit/8583c7769d6ffc650c3000414f4b631f076056a8) fix: failing checks - [`3570afc`](https://github.com/pocket-id/pocket-id/commit/3570afc0a214c81dcb39d3fd16d4b629201b254e) fix: faililng checks - [`afd428b`](https://github.com/pocket-id/pocket-id/commit/afd428b90096e0c49418257a7deb76f5331121ad) fix: failing checks - [`c478d27`](https://github.com/pocket-id/pocket-id/commit/c478d2710e4688a4356ba8edd0611f5d02224359) remove secrets ui - [`4688c07`](https://github.com/pocket-id/pocket-id/commit/4688c073a45bacd75f1ebf0fa2c44757158e6ce4) remove secret - [`e185af3`](https://github.com/pocket-id/pocket-id/commit/e185af3fe3768a178d274014c302872528dbec35) remove client secret frontend service - [`7ae66d2`](https://github.com/pocket-id/pocket-id/commit/7ae66d2b391fd32a5d7298694a61e87f28127018) remove redundant code ### 📊 Changes **8 files changed** (+234 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/errors.go` (+9 -0) 📝 `backend/internal/controller/oidc_controller.go` (+60 -0) 📝 `backend/internal/dto/oidc_dto.go` (+8 -0) 📝 `backend/internal/model/oidc.go` (+5 -0) 📝 `backend/internal/service/oidc_service.go` (+91 -0) 📝 `frontend/src/lib/services/oidc-service.ts` (+7 -1) 📝 `frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte` (+7 -1) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte` (+47 -8) </details> ### 📄 Description this PR includes changes to support a custom client id/client secret to be used for a client. This is required for services such as owncloud ocis, who use fixed client id/client secrets for some elements of their services. I believe this is not strictly in accordance with the oidc specs, so this is proposed as an advanced option only, after a client is setup in the usual manner. happy for input if things are not quite right - i have done preliminary testing and think it is ok. fixes #508. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:13:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?