[PR #858] [MERGED] feat: add custom base url #583

New Issue

OVERLORD · 2025-10-08T00:13:22+03:00

OVERLORD commented

2025-10-08 00:13:22 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/858
Author: @DerSteph
Created: 8/21/2025
Status: ✅ Merged
Merged: 8/30/2025
Merged by: @kmendell

Base: main ← Head: feature/customized-base-url

📝 Commits (4)

87395c2 feat: add custom base url
1d1812b refactor: use only one env variable
23abe06 feat: check internal url
ed21d24 Derive INTERNAL_APP_URL from APP_URL if not set

📊 Changes

3 files changed (+46 additions, -5 deletions)

View changed files

📝 backend/internal/common/env_config.go (+17 -1)
📝 backend/internal/common/env_config_test.go (+22 -0)
📝 backend/internal/controller/well_known_controller.go (+7 -4)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/857

Adds env variables which can customize the base urls used in well_known_controller.

Can be used for setups, where the oicd client cannot resolve the app url.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/858 **Author:** [@DerSteph](https://github.com/DerSteph) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 8/30/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `feature/customized-base-url` --- ### 📝 Commits (4) - [`87395c2`](https://github.com/pocket-id/pocket-id/commit/87395c252f5c1aad908bf2e94a8c628c16113f97) feat: add custom base url - [`1d1812b`](https://github.com/pocket-id/pocket-id/commit/1d1812b1d940592f3bd2ab3de9571fcbbc11bf2e) refactor: use only one env variable - [`23abe06`](https://github.com/pocket-id/pocket-id/commit/23abe06ab423ba9f4e970bdc0018a31be493f52b) feat: check internal url - [`ed21d24`](https://github.com/pocket-id/pocket-id/commit/ed21d240c0ff45688d387b21a926f928cef2f7b2) Derive INTERNAL_APP_URL from APP_URL if not set ### 📊 Changes **3 files changed** (+46 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/env_config.go` (+17 -1) 📝 `backend/internal/common/env_config_test.go` (+22 -0) 📝 `backend/internal/controller/well_known_controller.go` (+7 -4) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/857 Adds env variables which can customize the base urls used in well_known_controller. Can be used for setups, where the oicd client cannot resolve the app url. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-08 00:13:22 +03:00

OVERLORD closed this issue

2025-10-08 00:13:23 +03:00

OVERLORD referenced this issue

2025-10-08 00:16:03 +03:00

[PR #588] [MERGED] fix: don't use TOFU for logout callback URLs #728

OVERLORD referenced this issue

2025-10-08 00:16:06 +03:00

[PR #588] fix: don't use TOFU for logout callback URLs #731

OVERLORD referenced this issue

2025-10-08 00:16:12 +03:00

[PR #583] feat: auto detect callback url #736