starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #929] [MERGED] fix: add validation for callback URLs #545

New Issue
Open
opened 2025-10-08 00:12:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:12:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/929
Author: @stonith404
Created: 9/9/2025
Status: ✅ Merged
Merged: 9/10/2025
Merged by: @ItalyPaleAle

Base: main ← Head: fix/callback-url-validation

📝 Commits (2)

  • 90c5f7b fix: add validation for callback URLs
  • 8f430fa allow "*" callback urls

📊 Changes

4 files changed (+60 additions, -16 deletions)

View changed files

📝 backend/internal/dto/oidc_dto.go (+2 -2)
📝 backend/internal/dto/validations.go (+36 -11)
📝 frontend/src/lib/utils/zod-util.ts (+19 -0)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte (+3 -3)

📄 Description

Fixes #916

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/929 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 9/9/2025 **Status:** ✅ Merged **Merged:** 9/10/2025 **Merged by:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Base:** `main` ← **Head:** `fix/callback-url-validation` --- ### 📝 Commits (2) - [`90c5f7b`](https://github.com/pocket-id/pocket-id/commit/90c5f7b704b44ea692d22662fa8b49d3fdae514b) fix: add validation for callback URLs - [`8f430fa`](https://github.com/pocket-id/pocket-id/commit/8f430faab463133c5e101a2c4070ed58e2819f3f) allow "*" callback urls ### 📊 Changes **4 files changed** (+60 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/dto/oidc_dto.go` (+2 -2) 📝 `backend/internal/dto/validations.go` (+36 -11) 📝 `frontend/src/lib/utils/zod-util.ts` (+19 -0) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte` (+3 -3) </details> ### 📄 Description Fixes #916 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:12:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#545
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?