starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

[PR #940] [MERGED] fix: key-rotate doesn't work with database storage #539

New Issue
Open
opened 2025-10-08 00:12:32 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-08 00:12:32 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/940
Author: @ItalyPaleAle
Created: 9/13/2025
Status: ✅ Merged
Merged: 9/13/2025
Merged by: @kmendell

Base: main ← Head: fix-database-regen-key

📝 Commits (1)

  • d62bd8a fix: key-rotate doesn't work with database storage

📊 Changes

1 file changed (+9 additions, -1 deletions)

View changed files

📝 backend/internal/utils/jwk/key_provider_database.go (+9 -1)

📄 Description

If the key was already present in the database, key-rotate failed because the row wasn't replaced

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/940 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 9/13/2025 **Status:** ✅ Merged **Merged:** 9/13/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `fix-database-regen-key` --- ### 📝 Commits (1) - [`d62bd8a`](https://github.com/pocket-id/pocket-id/commit/d62bd8ab99e229b5aa35ce0fcc38c0b7c55ba254) fix: key-rotate doesn't work with database storage ### 📊 Changes **1 file changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/utils/jwk/key_provider_database.go` (+9 -1) </details> ### 📄 Description If the key was already present in the database, key-rotate failed because the row wasn't replaced --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-08 00:12:32 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?