[PR #994] [MERGED] feat: add the ability to make email optional #514

New Issue

OVERLORD · 2025-10-08T00:12:06+03:00

OVERLORD commented

2025-10-08 00:12:06 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/994
Author: @stonith404
Created: 10/1/2025
Status: ✅ Merged
Merged: 10/3/2025
Merged by: @stonith404

Base: main ← Head: feature/optional-email

📝 Commits (7)

d266a28 feat: add the ability to make email optional
bb0a189 fix case in label
e2c92d1 fix unit tests
49aab25 add backend validation for required email address
09f0e20 remove email from preview string
16715e5 fix e2e test service
e29db82 Merge branch 'main' into feature/optional-email

📊 Changes

44 files changed (+175 additions, -69 deletions)

View changed files

📝 backend/internal/common/errors.go (+10 -0)
📝 backend/internal/dto/app_config_dto.go (+1 -0)
📝 backend/internal/dto/user_dto.go (+7 -7)
📝 backend/internal/dto/user_dto_test.go (+8 -7)
📝 backend/internal/job/api_key_expiry_job.go (+1 -1)
📝 backend/internal/model/app_config.go (+1 -0)
📝 backend/internal/model/user.go (+6 -6)
📝 backend/internal/service/api_key_service.go (+5 -1)
📝 backend/internal/service/app_config_service.go (+1 -0)
📝 backend/internal/service/audit_log_service.go (+6 -2)
📝 backend/internal/service/e2etest_service.go (+2 -2)
📝 backend/internal/service/email_service.go (+5 -1)
📝 backend/internal/service/jwt_service_test.go (+10 -9)
📝 backend/internal/service/ldap_service.go (+2 -1)
📝 backend/internal/service/user_service.go (+14 -2)
📝 backend/internal/utils/ptr_util.go (+8 -5)
➕ backend/resources/migrations/postgres/20251001115300_optional_email.down.sql (+1 -0)
➕ backend/resources/migrations/postgres/20251001115300_optional_email.up.sql (+1 -0)
➕ backend/resources/migrations/sqlite/20251001115300_optional_email.down.sql (+1 -0)
➕ backend/resources/migrations/sqlite/20251001115300_optional_email.up.sql (+40 -0)

...and 24 more files

📄 Description

This PR adds the ability to make the email field optional:

Closes #867

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/994 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 10/1/2025 **Status:** ✅ Merged **Merged:** 10/3/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feature/optional-email` --- ### 📝 Commits (7) - [`d266a28`](https://github.com/pocket-id/pocket-id/commit/d266a284a7236e341331202e51c33d7727c5b9ab) feat: add the ability to make email optional - [`bb0a189`](https://github.com/pocket-id/pocket-id/commit/bb0a1894fbd3e9551a7888a09cd514e11f44de62) fix case in label - [`e2c92d1`](https://github.com/pocket-id/pocket-id/commit/e2c92d1a7ca591f72f6b1af929d548cab81e5e75) fix unit tests - [`49aab25`](https://github.com/pocket-id/pocket-id/commit/49aab253135c6a188d0c888213819b1b96254763) add backend validation for required email address - [`09f0e20`](https://github.com/pocket-id/pocket-id/commit/09f0e20b56b04343d225002beddfedcb3febfa68) remove email from preview string - [`16715e5`](https://github.com/pocket-id/pocket-id/commit/16715e545684860fff3158598a6b9d31ae8a053c) fix e2e test service - [`e29db82`](https://github.com/pocket-id/pocket-id/commit/e29db82778a043e4bc2befcfe0c93e1b8d2252c9) Merge branch 'main' into feature/optional-email ### 📊 Changes **44 files changed** (+175 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/errors.go` (+10 -0) 📝 `backend/internal/dto/app_config_dto.go` (+1 -0) 📝 `backend/internal/dto/user_dto.go` (+7 -7) 📝 `backend/internal/dto/user_dto_test.go` (+8 -7) 📝 `backend/internal/job/api_key_expiry_job.go` (+1 -1) 📝 `backend/internal/model/app_config.go` (+1 -0) 📝 `backend/internal/model/user.go` (+6 -6) 📝 `backend/internal/service/api_key_service.go` (+5 -1) 📝 `backend/internal/service/app_config_service.go` (+1 -0) 📝 `backend/internal/service/audit_log_service.go` (+6 -2) 📝 `backend/internal/service/e2etest_service.go` (+2 -2) 📝 `backend/internal/service/email_service.go` (+5 -1) 📝 `backend/internal/service/jwt_service_test.go` (+10 -9) 📝 `backend/internal/service/ldap_service.go` (+2 -1) 📝 `backend/internal/service/user_service.go` (+14 -2) 📝 `backend/internal/utils/ptr_util.go` (+8 -5) ➕ `backend/resources/migrations/postgres/20251001115300_optional_email.down.sql` (+1 -0) ➕ `backend/resources/migrations/postgres/20251001115300_optional_email.up.sql` (+1 -0) ➕ `backend/resources/migrations/sqlite/20251001115300_optional_email.down.sql` (+1 -0) ➕ `backend/resources/migrations/sqlite/20251001115300_optional_email.up.sql` (+40 -0) _...and 24 more files_ </details> ### 📄 Description This PR adds the ability to make the email field optional: <img width="1187" height="232" alt="Screenshot 2025-10-01 at 12 10 09" src="https://github.com/user-attachments/assets/a90d812f-6c43-4f9f-94d9-5766c85f292f" /> Closes #867 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-08 00:12:06 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#514