starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

🚀 Feature: remove restrictions on the group's name #416

New Issue
Closed
opened 2025-10-08 00:07:36 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2025-10-08 00:07:36 +03:00
Owner
Copy Link

Originally created by @VS-X on GitHub.

Feature description

Right now group's Name can only contain lowercase letters, numbers, and underscores. The current validation in pocket-id makes it impossible to create a group with dashes - for example.

I looked through the OIDC specification and couldn't find any restrictions on the group claim values. Other OAuth2 providers (Keycloak, Azure, Okta, etc.) allow many more characters, even uppercase letters and spaces in some cases. I wonder if it would be possible to remove the restriction or at least allow more characters? Or is there a technical reason, which I may have missed, why the restriction is in place?

Pitch

A service could expect a hardcoded group name that includes other characters like a dash - (e.g. service-admin, service-editor). Not being able to create such groups may make it impossible to use such service.

Originally created by @VS-X on GitHub. ### Feature description Right now group's Name can only contain lowercase letters, numbers, and underscores. The current validation in pocket-id makes it impossible to create a group with dashes `-` for example. I looked through the [OIDC specification](https://openid.net/specs/openid-connect-core-1_0.html) and couldn't find any restrictions on the group claim values. Other OAuth2 providers (Keycloak, Azure, Okta, etc.) allow many more characters, even uppercase letters and spaces in some cases. I wonder if it would be possible to remove the restriction or at least allow more characters? Or is there a technical reason, which I may have missed, why the restriction is in place? ### Pitch [A service](https://github.com/Zibbp/ganymede/wiki/SSO---OpenID-Connect#roles--groups) could expect a hardcoded group name that includes other characters like a dash `-` (e.g. `service-admin`, `service-editor`). Not being able to create such groups may make it impossible to use such service.
OVERLORD added the feature label 2025-10-08 00:07:36 +03:00
OVERLORD commented 2025-10-08 00:07:40 +03:00
Author
Owner
Copy Link

@stonith404 commented on GitHub:

This should be fixed in v0.24.1. I thought it would make sense to restrict it to keep consistency in the names but I didn't think about hardcoded group names.

@stonith404 commented on GitHub: This should be fixed in `v0.24.1`. I thought it would make sense to restrict it to keep consistency in the names but I didn't think about hardcoded group names.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#416
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?