mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-11 07:42:58 +03:00
🚀 Feature: allow setting Logo directly from https://selfh.st/icons/ #390
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kamilkosek on GitHub.
Feature description
I think this is more a QoL or convenience feature, so if it is considered unnecessary, it is not a problem.
Pitch
Additional to be able to upload a logo, it would be relly nice to directly select a logo from https://selfh.st/icons/ (or any other provider) .
@stonith404 commented on GitHub:
That’s an interesting idea, but I believe it could unnecessarily complicate Pocket ID. While it would certainly be convenient to save a few seconds by selecting the icon directly without downloading it, we would then need to support additional icon providers, which could introduce further complexity.
I hope you understand my decision.
@leleogere commented on GitHub:
Not sure about a checkbox, I would find more natural a UI similar to Notion's page icon selector:
(the second image is the last version, but maybe the first one with an explicit text field would be more appropriate)
I won't have the time to come up with a PR anytime soon, but I let this here in case someone else is interested later on.
@kmendell commented on GitHub:
@stonith404 I could maybe see a world where we add a checkbox to say "Use Picture URL?" if checked the upload profile picture part would just be a text box instead, but thats seems a bit involved to implement. Ill leave it up to you.
@leleogere commented on GitHub:
While I understand this decision, I can be quite long to download an icon locally, and then to upload it to Pocket ID, especially when you have a lot of services. Maybe an intermediate idea would be to allow the user to directly provide a URL to a logo? That way, I can simply copy the link image on https://selfh.st/icons (or any other image on the web), and paste it on Pocket ID, that would be in charge to download it. Do you think this would introduce too much complexity?