mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-11 07:42:58 +03:00
🐛 Bug Report: Pocket ID uses STARTTLS used by default if SMPT port is not 465 #326
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @savely-krasovsky on GitHub.
Originally assigned to: @kmendell on GitHub.
Reproduction steps
I think we need to provide a proper way to select TLS and STARTTLS. In my case provider blocks all SMTP ports, but provides a proxy which can be used with any arbitrary port (e.g. 443). I tried to enable TLS, but it tries STARTTLS in that case, while proxy supports only TLS.
Also I find it a little bit confusing that TLS option could activate STARTTLS at all.
Expected behavior
An option to select TLS or STARTTLS implicitly.
Actual Behavior
One TLS option which can lead to either TLS or STARTTLS
Version and Environment
v0.35.1
Log Output
No response
@kmendell commented on GitHub:
@savely-krasovsky Are you wanting a dropdown box to select the TLS option? right now the email ports automatcially select TLS if the port is 465, and StartTLS if the port is 587, and no TLS if the port is 25
@kmendell commented on GitHub:
@savely-krasovsky Im assuming that was a typo you meant to put that in the other issue? Either way i will try to work on this a bit later today.
@savely-krasovsky commented on GitHub:
@kmendell yep, in my case 25, 465 and 587 are blocked. But Fastmail has SMTP proxy which can be used with any port, but it requires TLS support (not STARTTLS). Dropdown would be nice.
@savely-krasovsky commented on GitHub:
I prepared PR #265, will test it today.
@savely-krasovsky commented on GitHub:
Yep, sorry!
@kmendell commented on GitHub:
@savely-krasovsky I made PR #268 , but this is what i came up with , just as a fyi for you
@stonith404 commented on GitHub:
Released in
v0.35.3. Thanks @kmendell.