mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 14:53:00 +03:00
🐛 Bug Report: Setting UI_CONFIG_DISABLED breaks uploaded Application Configuration > Images #211
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @michaelbeaumont on GitHub.
Reproduction steps
When I upload a new background image and then disable config via UI, the background image is no longer loaded,
/api/application-configuration/background-imagereturns 404 and the alt text is displayed.Expected behavior
Already uploaded images should still work even after disabling UI config. Alternatively, their paths should be configurable via environment variables.
Actual Behavior
Images can no longer be loaded
Version and Environment
As described above.
Log Output
@RealOrangeOne commented on GitHub:
I had this happen to me. I think the solution is to set
$BACKGROUND_IMAGE_TYPEto the format of the image (happened to me when uploading a PNG). Once$PUBLIC_UI_CONFIG_DISABLEDis set, any configuration set through the UI (which includes what format the background image is) is ignored and falls back to the environment.@stonith404 commented on GitHub:
Thanks for reporting this. This should be fixed in
bf710aec56and will be released in the next release.@michaelbeaumont commented on GitHub:
I'll give it a try! If it works I guess it just needs to be documented. These config setting are marked as "internal" in the code.
EDIT: it does work but won't be necessary for much longer