mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 14:53:00 +03:00
🐛 Bug Report: Emails have a missing image #177
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dougmeredith on GitHub.
Reproduction steps
Sign into a new location so that a notification email is sent to the user.
Expected behavior
There should not be missing images in the email message.
Actual Behavior
In the message body, to the left of the application name, there is a missing image.
Version and Environment
v1.2.0
The image doesn't show in the Fastmail web UI nor in the Gmail web UI.
Log Output
No response
@dougmeredith commented on GitHub:
No the instance isn't Internet accessible yet. Does that matter? I was assuming this was an embedded image, not a link.
@bfqrst commented on GitHub:
Yeah it's a Gmail thing, I noticed that too...
@stonith404 commented on GitHub:
Is you instance publicly accessible? If yes, please try to convert the logo into a PNG and upload it in the UI. It seems like Gmail doesn't support SVGs according this https://github.com/pocket-id/pocket-id/issues/240#issuecomment-2819710454.
@dougmeredith commented on GitHub:
I just set up an Internet-accessible Pocket ID instance, and I can confirm that the image shows correctly on Fastmail. Thanks for the information.
@stonith404 commented on GitHub:
Okay then that's the reason why the image can't be loaded in Fastmail. Fastmail proxies the images trough their servers, so if Pocket ID isn't accessible publicly the images can't be loaded.
Embedded images are supported in less email clients for example Gmail doesn't allow embedded but we would need to add the image as an attachment which is ugly in my opinion.
I don't plan to implement changes specifically for email rendering compatibility, as it's a rabbit hole, each email client handles rendering differently. However, I'm open to reviewing pull requests if someone wants to tackle improving email client compatibility.
@dougmeredith commented on GitHub:
I totally get not wanting to go down the rabbit hole of trying to accommodate the email rendering of various email clients. I have to wonder if the best solution is to just not include an image in the email at all, as you're going to get more and more issues raised about this, as Pocket ID adoption grows.