starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:53:00 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

🐛 Bug Report: Possible race condition when using Postgres #153

New Issue
Closed
opened 2025-10-07 23:55:29 +03:00 by OVERLORD · 3 comments
OVERLORD commented 2025-10-07 23:55:29 +03:00
Owner
Copy Link

Originally created by @ItalyPaleAle on GitHub.

Reproduction steps

This CI test failed because the Pocket ID binary crashed due to a data race.

The test succeeded on 2nd attempt, indicating some flakiness.

It seems that the data race is in the Gorm library, but there may be something we can do in Pocket ID itself to prevent them.

Opening this issue so I can look into it later.

Expected behavior

Should not have data races

Actual Behavior

Data race causes the binary to crash during test

Version and Environment

main

Log Output

backend.log

Originally created by @ItalyPaleAle on GitHub. ### Reproduction steps [This CI test](https://github.com/pocket-id/pocket-id/actions/runs/15890219851/job/44811337395) failed because the Pocket ID binary crashed due to a data race. The test succeeded on 2nd attempt, indicating some flakiness. It seems that the data race is in the Gorm library, but there may be something we can do in Pocket ID itself to prevent them. Opening this issue so I can look into it later. ### Expected behavior Should not have data races ### Actual Behavior Data race causes the binary to crash during test ### Version and Environment main ### Log Output [backend.log](https://github.com/user-attachments/files/20929498/backend.log)
OVERLORD commented 2025-10-07 23:55:32 +03:00
Author
Owner
Copy Link

@ItalyPaleAle commented on GitHub:

This really seems an issue upstream. I've opened go-gorm/gorm#7539

Will close this issue. When it's fixed, I'll update Pocket ID

@ItalyPaleAle commented on GitHub: This really seems an issue upstream. I've opened go-gorm/gorm#7539 Will close this issue. When it's fixed, I'll update Pocket ID
OVERLORD commented 2025-10-07 23:55:32 +03:00
Author
Owner
Copy Link

@ItalyPaleAle commented on GitHub:

It happened once in a test (which is not unusual for race conditions). I will take another look, it's not even clear if the bug is in our code or in gorm (the goroutine that crashed was gorm's).

@ItalyPaleAle commented on GitHub: It happened once in a test (which is not unusual for race conditions). I will take another look, it's not even clear if the bug is in our code or in gorm (the goroutine that crashed was gorm's).
OVERLORD commented 2025-10-07 23:55:33 +03:00
Author
Owner
Copy Link

@kmendell commented on GitHub:

@ItalyPaleAle did you want to look at this, elias nor i can reproduce it.

@kmendell commented on GitHub: @ItalyPaleAle did you want to look at this, elias nor i can reproduce it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#153
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?