mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 14:53:00 +03:00
🚀 Feature: Dark mode OIDC Client Icons #129
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @shelldandy on GitHub.
Originally assigned to: @kmendell on GitHub.
Feature description
Let's add an optional dark mode (or light mode) icon for the OIDC Clients.
In dashboard icons both versions are usually provided and it would be nice to have them in here for UX:
https://dashboardicons.com/icons/karakeep
Pitch
Optional dark logo would be nice so the OIDC client lists looks nice on both color schemes
@jloh commented on GitHub:
I opened the original issue that was closed. I have several apps that have light/dark icons that would greatly appreciate this. I think the fact that Pocket ID itself has a light/dark variation for its icon hints towards it being a wanted feature.
@michaelbeaumont commented on GitHub:
Duplicate of https://github.com/pocket-id/pocket-id/issues/178
@kmendell commented on GitHub:
Elias and i have though about this from a previous issue in the past. Our thought were that it would clutter the ui have two different image selctors when id say 80% of icons have a universal variant, This was awhile ago though so maybe we could havea chnage of heart. Ill leave this open till @stonith404 gets back and puts his opinion.
@Elyviere commented on GitHub:
I think this could be relatively cleanly added by simply adding a light/dark toggle by the icon buttons. Please excuse my terrible paint skills, it's meant to be a sun/moon but use whatever light/dark switch Pocketid already has.
Upon uploading an image, the same image is set for light/dark mode. The preselected option matches your UI, so if you're using PocketID in dark mode then dark mode is preselected. When switching to light/dark mode, the only change is that the background of the image changes. If the user now uploads a new image, it is only set for that mode.
In summary,
When adding a new icon:
When removing an icon:
@fred8044 commented on GitHub:
I hope this feature will be implemented.
@janreinhardt commented on GitHub:
Errr, does Pocket-ID itself have a switch for dark mode? Cant find it!
But in the settings, there are 2 application logos for light and for dark mode (?), this applies to situations when this is set via a browser preference?