🚀 Feature: Modification audit, commented #106

New Issue

OVERLORD · 2025-10-07T23:53:21+03:00

OVERLORD commented

2025-10-07 23:53:21 +03:00

Originally created by @jtagcat on GitHub.

Feature description

Audit log for user modifications (or considering PII laws, accessing/viewing).

I heavily recommend a text box (with a placeholder) for an optional 'commit message' next to the Save button. For design inspiration, see editing files in web for GitHub, GitLab, Gitea, etc.

Pitch

We store our users in Git, which is synced by ArgoCD to passmower. The advantages:

Committing encourages a commit message. Audit log is great for blaming 'what by whom?', but 'why?' is much more useful to debug people operations, especially with many independent editors.
Everything is plaintext. Mass modification, surgical filtering with yq is trivial. Time has shown it also answers 'whose phone nr?' or finding the guy with 3 alias-names with ripgrep.
It may be bad, but adding to the 'why' factor, we have comments in yaml to cite a source for the piece of information, or warn against repeat headaches.

This is our niche use-case with technocrats running the show.

Originally created by @jtagcat on GitHub. ### Feature description Audit log for user modifications (or considering PII laws, accessing/viewing). I heavily recommend a text box (with a [placeholder](https://developer.mozilla.org/en-US/docs/Web/CSS/::placeholder)) for an optional 'commit message' next to the Save button. For design inspiration, see editing files in web for GitHub, GitLab, Gitea, etc. ### Pitch We store our users in Git, which is synced by ArgoCD to [passmower](https://github.com/passmower/passmower). The advantages: - Committing encourages a commit message. Audit log is great for blaming 'what by whom?', but 'why?' is much more useful to debug people operations, especially with many independent editors. - Everything is plaintext. Mass modification, surgical filtering with yq is trivial. Time has shown it also answers 'whose phone nr?' or finding the guy with 3 alias-names with ripgrep. - It may be bad, but adding to the 'why' factor, we have comments in yaml to cite a source for the piece of information, or warn against repeat headaches. This is our niche use-case with technocrats running the show.

OVERLORD closed this issue

2025-10-07 23:53:22 +03:00

OVERLORD commented

2025-10-07 23:53:23 +03:00

@jtagcat commented on GitHub:

What about uncommented audit logs? Honestly, I expected modifications (/ admin actions, including viewing) under the current audit logs, but don't be bothered by my opinion.

@jtagcat commented on GitHub: What about uncommented audit logs? Honestly, I expected modifications (/ admin actions, including viewing) under the current audit logs, but don't be bothered by my opinion.

OVERLORD commented

2025-10-07 23:53:24 +03:00

@stonith404 commented on GitHub:

Thank you for your suggestion. While I think the idea is not bad, I believe this feature is too complex for a simple OIDC provider like Pocket ID. Commented audit logs seem more suited for an enterprise-level IDP, which Pocket ID is not.

@stonith404 commented on GitHub: Thank you for your suggestion. While I think the idea is not bad, I believe this feature is too complex for a simple OIDC provider like Pocket ID. Commented audit logs seem more suited for an enterprise-level IDP, which Pocket ID is not.

OVERLORD commented

2025-10-07 23:53:24 +03:00

@kmendell commented on GitHub:

I think this may be overkill and would add bloat to the UI when its a niche feature, that a small subset of users would use, but ill leave it up to @stonith404

@kmendell commented on GitHub: I think this may be overkill and would add bloat to the UI when its a niche feature, that a small subset of users would use, but ill leave it up to @stonith404

OVERLORD referenced this issue

2025-10-08 00:20:22 +03:00

[PR #106] [MERGED] feat: add LDAP sync #954

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-1#106