starred/pocket-id-pocket-id-1
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-26 06:54:45 +03:00
Code Issues 122 Packages Projects Releases 10 Wiki Activity

fix: skip ldap objects without a valid unique id (#376)

Browse Source 
Co-authored-by: Elias Schneider <login@eliasschneider.com>
This commit is contained in:
Kyle Mendell
2025-03-23 13:30:12 -05:00
committed by GitHub
parent e2f74e5687
commit cdfe8161d4
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
backend/internal/service/ldap_service.go
View File

@@ -98,6 +98,13 @@ func (s *LdapService) SyncGroups() error {
var membersUserId []string var membersUserId []string
ldapId := value.GetAttributeValue(uniqueIdentifierAttribute) ldapId := value.GetAttributeValue(uniqueIdentifierAttribute)
// Skip groups without a valid LDAP ID
if ldapId == "" {
log.Printf("Skipping LDAP group without a valid unique identifier (attribute: %s)", uniqueIdentifierAttribute)
continue
}
ldapGroupIDs[ldapId] = true ldapGroupIDs[ldapId] = true
// Try to find the group in the database // Try to find the group in the database
@@ -216,6 +223,13 @@ func (s *LdapService) SyncUsers() error {
for _, value := range result.Entries { for _, value := range result.Entries {
ldapId := value.GetAttributeValue(uniqueIdentifierAttribute) ldapId := value.GetAttributeValue(uniqueIdentifierAttribute)
// Skip users without a valid LDAP ID
if ldapId == "" {
log.Printf("Skipping LDAP user without a valid unique identifier (attribute: %s)", uniqueIdentifierAttribute)
continue
}
ldapUserIDs[ldapId] = true ldapUserIDs[ldapId] = true
// Get the user from the database // Get the user from the database