[PR #311] [CLOSED] WIP: SAML support (backend) #985

New Issue

OVERLORD · 2026-02-04T21:42:19+03:00

OVERLORD commented

2026-02-04 21:42:19 +03:00

📋 Pull Request Information

Original PR: https://github.com/plankanban/planka/pull/311
Author: @SimonTagne
Created: 10/15/2022
Status: ❌ Closed

Base: master ← Head: saml

📝 Commits (10+)

e564729 Fix typo in en-US translation. Closes #1
2566ff3 Add email and password change functionality for a current user, remove deep compare hooks
e07b0bc Fix timer counting, fix flickering on comment creation, update dependencies
9785641 Update dependencies
0e9ae2a Remove axios from dependencies
671bfc5 Update dependencies
f96c3e8 Update dependencies
17d2781 Update dependencies
859c09d Fix api transformers, intercept by error message instead of undefined
3896e06 Update dependencies

📊 Changes

19 files changed (+729 additions, -7 deletions)

View changed files

📝 server/.env.sample (+5 -0)
📝 server/api/controllers/access-tokens/create.js (+10 -0)
📝 server/api/controllers/access-tokens/delete.js (+25 -3)
➕ server/api/controllers/authentication/index.js (+8 -0)
➕ server/api/controllers/authentication/saml/acs.js (+87 -0)
➕ server/api/controllers/authentication/saml/login-request.js (+41 -0)
➕ server/api/controllers/authentication/saml/metadata.js (+22 -0)
➕ server/api/helpers/saml/get-config.js (+29 -0)
➕ server/api/helpers/saml/parse-attributes.js (+36 -0)
📝 server/api/helpers/users/get-one-by-email-or-username.js (+11 -3)
📝 server/api/models/Session.js (+4 -0)
📝 server/api/models/User.js (+11 -1)
➕ server/api/responses/serverError.js (+36 -0)
📝 server/config/custom.js (+3 -0)
📝 server/config/policies.js (+4 -0)
📝 server/config/routes.js (+6 -0)
➕ server/db/migrations/20221009201347_add_sso_fields.js (+21 -0)
📝 server/package-lock.json (+368 -0)
📝 server/package.json (+2 -0)

📄 Description

This is the back-end part for SAML authentication support.

Here are a few points where I would appreciate some advice:

The configuration in json is not really readable, especially when including PEM certs/keys
The constants for the authentication cookies are defined in the client source tree, and I don't know any good solution to access it in the ACS endpoint (it's hardcoded for now)

I'll start working on the front-end now and keep you updated

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/plankanban/planka/pull/311 **Author:** [@SimonTagne](https://github.com/SimonTagne) **Created:** 10/15/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `saml` --- ### 📝 Commits (10+) - [`e564729`](https://github.com/plankanban/planka/commit/e564729598b5f7e9d892ed4541d99a865fd1046b) Fix typo in en-US translation. Closes #1 - [`2566ff3`](https://github.com/plankanban/planka/commit/2566ff376ed55b8225748407ebdf9e00d778f7d0) Add email and password change functionality for a current user, remove deep compare hooks - [`e07b0bc`](https://github.com/plankanban/planka/commit/e07b0bc5b1c9f43fcd7f1dada2680148314f2a8b) Fix timer counting, fix flickering on comment creation, update dependencies - [`9785641`](https://github.com/plankanban/planka/commit/97856411a9a8b0a93a71d6342b68c83bc46b2589) Update dependencies - [`0e9ae2a`](https://github.com/plankanban/planka/commit/0e9ae2a715b28310cc2eb28c7e607e60eca11641) Remove axios from dependencies - [`671bfc5`](https://github.com/plankanban/planka/commit/671bfc5efa058e412515b6626bf18ddf19fb251f) Update dependencies - [`f96c3e8`](https://github.com/plankanban/planka/commit/f96c3e83de75f6bb6f68bb3658ac79817b5a4f7c) Update dependencies - [`17d2781`](https://github.com/plankanban/planka/commit/17d2781d33f939113b1800cd0e64e5ca279b05db) Update dependencies - [`859c09d`](https://github.com/plankanban/planka/commit/859c09d05e0d4dda6494f718e98092408a06bda3) Fix api transformers, intercept by error message instead of undefined - [`3896e06`](https://github.com/plankanban/planka/commit/3896e0688ef1fc26f690687b273497a99c154874) Update dependencies ### 📊 Changes **19 files changed** (+729 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `server/.env.sample` (+5 -0) 📝 `server/api/controllers/access-tokens/create.js` (+10 -0) 📝 `server/api/controllers/access-tokens/delete.js` (+25 -3) ➕ `server/api/controllers/authentication/index.js` (+8 -0) ➕ `server/api/controllers/authentication/saml/acs.js` (+87 -0) ➕ `server/api/controllers/authentication/saml/login-request.js` (+41 -0) ➕ `server/api/controllers/authentication/saml/metadata.js` (+22 -0) ➕ `server/api/helpers/saml/get-config.js` (+29 -0) ➕ `server/api/helpers/saml/parse-attributes.js` (+36 -0) 📝 `server/api/helpers/users/get-one-by-email-or-username.js` (+11 -3) 📝 `server/api/models/Session.js` (+4 -0) 📝 `server/api/models/User.js` (+11 -1) ➕ `server/api/responses/serverError.js` (+36 -0) 📝 `server/config/custom.js` (+3 -0) 📝 `server/config/policies.js` (+4 -0) 📝 `server/config/routes.js` (+6 -0) ➕ `server/db/migrations/20221009201347_add_sso_fields.js` (+21 -0) 📝 `server/package-lock.json` (+368 -0) 📝 `server/package.json` (+2 -0) </details> ### 📄 Description This is the back-end part for SAML authentication support. Here are a few points where I would appreciate some advice: - The configuration in json is not really readable, especially when including PEM certs/keys - The constants for the authentication cookies are defined in the client source tree, and I don't know any good solution to access it in the ACS endpoint (it's hardcoded for now) I'll start working on the front-end now and keep you updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-04 21:42:19 +03:00

OVERLORD closed this issue

2026-02-04 21:42:24 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/planka#985