mirror of
https://github.com/plankanban/planka.git
synced 2026-02-25 03:14:50 +03:00
[PR #237] [MERGED] Improvements for docker build process #964
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/plankanban/planka/pull/237
Author: @ThelonKarrde
Created: 5/1/2022
Status: ✅ Merged
Merged: 5/4/2022
Merged by: @meltyshev
Base:
master← Head:feature/build_improvements📝 Commits (10+)
52f7ff7Github actions config for dockerb6167d7Add name and multi-arch buildf25362aUpdate pipeline name7d827f5Delete pvc.yaml77d2ae6Different arch def9de539cUpdate docker.yamlc33a37cUpdate docker.yamldac7599Update docker.yamlb8a3d16Update docker.yamlb1b97acupdate docker-build📊 Changes
5 files changed (+80 additions, -33 deletions)
View changed files
➕
.github/workflows/build-and-push-docker-base-image.yaml(+44 -0)📝
.gitignore(+1 -0)📝
Dockerfile(+4 -32)➕
Dockerfile.base(+28 -0)📝
package.json(+3 -1)📄 Description
So the current problem with the build process is that it builds each time the entire
vipslibrary which takes the majority of the time. In case it would be easy to make a build cache for Github Actions it wouldn't be a problem, however, since it is I suggest a little different approach.Let's have a
build-baseimage which will include pre-buildvipslibrary with other packages and then in regular build this will use it as a base and no necessity to build vips lib every day.I also added a couple of shortcuts to
package.jsonfor easier local development.A little controversial thing is to use the alpine version as a source of version for the image tag, but that's the simplest approach.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.