Modal not opening -> js error #50

New Issue

OVERLORD · 2026-02-04T16:48:02+03:00

OVERLORD commented

2026-02-04 16:48:02 +03:00

Originally created by @caplod on GitHub (Dec 11, 2020).

If you click on a card that has a comment from a deleted user, the modal doesnt open and there is a black page.

react-dom.production.min.js:216 TypeError: Cannot read property 'ref' of null

I think its this line:

export const actionsForCurrentCardSelector = createSelector(
  orm,
  (state) => pathSelector(state).cardId,
  (state) => currentUserIdSelector(state),
  ({ Card }, id, currentUserId) => {
    if (!id) {
      return id;
    }

    const cardModel = Card.withId(id);

    if (!cardModel) {
      return cardModel;
    }

    return cardModel
      .getOrderedInCardActionsQuerySet()
      .toModelArray()
      .map((actionModel) => ({
        ...actionModel.ref,
        isPersisted: !isLocalId(actionModel.id),
        user: {
          ...actionModel.user.ref, // <- here is the error because user is null
          isCurrent: actionModel.user.id === currentUserId,
        },
      }));
  },
);

Originally created by @caplod on GitHub (Dec 11, 2020). If you click on a card that has a comment from a deleted user, the modal doesnt open and there is a black page. `react-dom.production.min.js:216 TypeError: Cannot read property 'ref' of null` I think its this line: ``` export const actionsForCurrentCardSelector = createSelector( orm, (state) => pathSelector(state).cardId, (state) => currentUserIdSelector(state), ({ Card }, id, currentUserId) => { if (!id) { return id; } const cardModel = Card.withId(id); if (!cardModel) { return cardModel; } return cardModel .getOrderedInCardActionsQuerySet() .toModelArray() .map((actionModel) => ({ ...actionModel.ref, isPersisted: !isLocalId(actionModel.id), user: { ...actionModel.user.ref, // <- here is the error because user is null isCurrent: actionModel.user.id === currentUserId, }, })); }, ); ```

OVERLORD added the bug label 2026-02-04 16:48:02 +03:00

OVERLORD closed this issue

2026-02-04 16:48:08 +03:00

OVERLORD commented

2026-02-04 16:48:22 +03:00

@nickbe commented on GitHub (Dec 11, 2020):

Actually if you delete a user then his cards should be deleted with him OR the user might be only marked as deleted as long as there are other members on his boards.

This will be something to investigate in the new version though. And I don't think the follow up to user deletion is already fully implemented.

@nickbe commented on GitHub (Dec 11, 2020): Actually if you delete a user then his cards should be deleted with him OR the user might be only marked as deleted as long as there are other members on his boards. This will be something to investigate in the new version though. And I don't think the follow up to user deletion is already fully implemented.

OVERLORD commented

2026-02-04 16:48:24 +03:00

@caplod commented on GitHub (Dec 11, 2020):

Just to make things clear.
Not the owner of the card was deleted, only the user that made the comment on the card.

@caplod commented on GitHub (Dec 11, 2020): Just to make things clear. Not the owner of the card was deleted, only the user that made the comment on the card.

OVERLORD commented

2026-02-04 16:48:30 +03:00

@meltyshev commented on GitHub (Dec 13, 2020):

This is definitely a bug. Thank you for reporting. Already working on a fix.

@meltyshev commented on GitHub (Dec 13, 2020): This is definitely a bug. Thank you for reporting. Already working on a fix.

OVERLORD commented

2026-02-04 16:48:38 +03:00

@meltyshev commented on GitHub (Dec 13, 2020):

Fixed. Please check it out! Docker image will be available a bit later because it takes ~4 hours on my PC to build for all architectures.

@meltyshev commented on GitHub (Dec 13, 2020): Fixed. Please check it out! Docker image will be available a bit later because it takes ~4 hours on my PC to build for all architectures.

OVERLORD commented

2026-02-04 16:48:44 +03:00

@caplod commented on GitHub (Dec 17, 2020):

Hi, I just checked on hub.docker.com. When are you planning to release a new version?

@caplod commented on GitHub (Dec 17, 2020): Hi, I just checked on hub.docker.com. When are you planning to release a new version?

OVERLORD commented

2026-02-04 16:48:48 +03:00

@meltyshev commented on GitHub (Dec 17, 2020):

Oops, I forgot to start a build. Starting now...

@meltyshev commented on GitHub (Dec 17, 2020): Oops, I forgot to start a build. Starting now...

OVERLORD commented

2026-02-04 16:48:52 +03:00