starred/planka
1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2026-02-24 19:08:59 +03:00
Code Issues 396 Packages Projects Releases 16 Wiki Activity

Update Sails.js configuration to fix TRUST_PROXY flag #223

New Issue
Closed
opened 2026-02-04 17:55:44 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-04 17:55:44 +03:00
Owner
Copy Link

Originally created by @StevenJCorreia on GitHub (Aug 31, 2022).

After my I implemented #283, I finally got around to integrating it into my production server and noticed that the remote (client) IP address was not being correctly forwarded through the proxy.

I realized that this is due to Sails.js requiring that http.trustProxy be a boolean, not a number like we are currently passing it. I assumed that Sails.js would just boolean-wrap the given value but it seems that is not the case here...

With that being said, the intended fix here would be to simply boolean-wrap the value as, for some reason, the application breaks on initialization if TRUST_PROXY is set to a boolean over a number within the docker-compose file.

Note: Funny enough, if you run this in development with TRUST_PROXY=true in the .env file, everything works - so maybe a docker-compose issue?

Either way, let me know if I can go ahead and implement the fix.

Originally created by @StevenJCorreia on GitHub (Aug 31, 2022). After my I implemented #283, I finally got around to integrating it into my production server and noticed that the remote (client) IP address was not being correctly forwarded through the proxy. I realized that this is due to Sails.js requiring that `http.trustProxy` be a `boolean`, not a `number` like we are currently passing it. I assumed that Sails.js would just boolean-wrap the given value but it seems that is not the case here... With that being said, the intended fix here would be to simply boolean-wrap the value as, for some reason, the application breaks on initialization if `TRUST_PROXY` is set to a boolean over a number within the `docker-compose` file. Note: Funny enough, if you run this in development with `TRUST_PROXY=true` in the `.env` file, everything works - so maybe a docker-compose issue? Either way, let me know if I can go ahead and implement the fix.
OVERLORD commented 2026-02-04 17:55:49 +03:00
Author
Owner
Copy Link

@meltyshev commented on GitHub (Sep 2, 2022):

Sure! Please make a PR with a fix 🙏

@meltyshev commented on GitHub (Sep 2, 2022): Sure! Please make a PR with a fix 🙏
OVERLORD commented 2026-02-04 17:55:57 +03:00
Author
Owner
Copy Link

@meltyshev commented on GitHub (Sep 3, 2022):

Fixed by https://github.com/plankanban/planka/pull/295. Thank you!

@meltyshev commented on GitHub (Sep 3, 2022): Fixed by https://github.com/plankanban/planka/pull/295. Thank you!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
documentation
documentation
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/planka#223
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?