starred/planka
1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2026-02-05 00:39:58 +03:00
Code Issues 396 Packages Projects Releases 10 Wiki Activity

directory in BASE_URL is partially ignored #211

New Issue
Closed
opened 2026-02-04 17:52:12 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2026-02-04 17:52:12 +03:00
Owner
Copy Link

Originally created by @andidevi on GitHub (Jul 18, 2022).

If you set a directory in BASE_URL like

BASE_URL=http://127.0.0.1:3000/planka

planka is served from /planka but the html still loads assets from /static/… and /manifest.json instead of
/planka/static/… and /manifest.json.

That files are also served from the wrong place so BASE_URL is only honored for the basic html, but everything else is outside the defined base.

This also may affect #43 and #111, but those issues also discuss other unrelated problems.

Originally created by @andidevi on GitHub (Jul 18, 2022). If you set a directory in BASE_URL like ``` BASE_URL=http://127.0.0.1:3000/planka ``` planka is served from `/planka` but the html still loads assets from `/static/…` and `/manifest.json` instead of `/planka/static/…` and `/manifest.json`. That files are also served from the wrong place so BASE_URL is only honored for the basic html, but everything else is outside the defined base. This also may affect #43 and #111, but those issues also discuss other unrelated problems.
OVERLORD added the bug label 2026-02-04 17:52:12 +03:00
OVERLORD commented 2026-02-04 17:52:27 +03:00
Author
Owner
Copy Link

@jacqueslorentz commented on GitHub (Sep 25, 2022):

Hi all!
I faced the same issue!
The React application path is not configured with the BASE_URL variable, not very complex.
But it seems that the lib sails.io.js used for websocket does not support url path and is not actively maintained anymore.

In the call of sails.io.js dependency socket.io-client
88b96ea019/sails.io.js (L884)

A specific socket connection path requires some additional option: https://socket.io/docs/v2/client-api/#with-custom-path

I will propose a PR to fix this issue soon.

Have a good day all!

@jacqueslorentz commented on GitHub (Sep 25, 2022): Hi all! I faced the same issue! The React application path is not configured with the BASE_URL variable, not very complex. But it seems that the lib `sails.io.js` used for websocket does not support url path and is not actively maintained anymore. In the call of `sails.io.js` dependency `socket.io-client` https://github.com/balderdashy/sails.io.js/blob/88b96ea019db4a03a1fb5fff0600dc7fd23f7862/sails.io.js#L884 A specific socket connection path requires some additional option: https://socket.io/docs/v2/client-api/#with-custom-path I will propose a PR to fix this issue soon. Have a good day all!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
documentation
documentation
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/planka#211
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?