[PR #962] [MERGED] fix: quote variables to prevent word splitting #1157

Closed
opened 2026-02-04 21:54:10 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/plankanban/planka/pull/962
Author: @florczakraf
Created: 11/26/2024
Status: Merged
Merged: 11/27/2024
Merged by: @meltyshev

Base: masterHead: quote-docker-backup-scripts


📝 Commits (1)

  • 9f355db fix: quote variables to prevent word splitting

📊 Changes

2 files changed (+18 additions, -18 deletions)

View changed files

📝 docker-backup.sh (+11 -11)
📝 docker-restore.sh (+7 -7)

📄 Description

docker-backup.sh and docker-restore.sh didn't quote variables, which prevented them from running in certain environments. This PR adds consistent quotation for all variables in those scripts.

Ref.: https://www.shellcheck.net/wiki/SC2046 https://www.shellcheck.net/wiki/SC2086


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/plankanban/planka/pull/962 **Author:** [@florczakraf](https://github.com/florczakraf) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 11/27/2024 **Merged by:** [@meltyshev](https://github.com/meltyshev) **Base:** `master` ← **Head:** `quote-docker-backup-scripts` --- ### 📝 Commits (1) - [`9f355db`](https://github.com/plankanban/planka/commit/9f355db47e3cca2f45f6a746295a8c40cae24c8f) fix: quote variables to prevent word splitting ### 📊 Changes **2 files changed** (+18 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `docker-backup.sh` (+11 -11) 📝 `docker-restore.sh` (+7 -7) </details> ### 📄 Description `docker-backup.sh` and `docker-restore.sh` didn't quote variables, which prevented them from running in certain environments. This PR adds consistent quotation for all variables in those scripts. Ref.: https://www.shellcheck.net/wiki/SC2046 https://www.shellcheck.net/wiki/SC2086 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:54:10 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/planka#1157