starred/planka
1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2026-03-01 11:21:46 +03:00
Code Issues 396 Packages Projects Releases 16 Wiki Activity

[PR #948] [MERGED] fix: apple-touch-icon not found #1154

New Issue
Closed
opened 2026-02-04 21:53:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 21:53:54 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/plankanban/planka/pull/948
Author: @knif3
Created: 11/18/2024
Status: ✅ Merged
Merged: 11/19/2024
Merged by: @meltyshev

Base: master ← Head: fix/icon-path

📝 Commits (1)

  • 4200899 fix: apple-touch-icon not found

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 client/public/index.html (+1 -1)

📄 Description

Description

Opening a project page directly by its URL link causes a 404 Not Found error for the http://planka/boards/logo192.png path.
If we open it from the main page, this basic part is already loaded and won't re-render after navigating, but accessing a specific project or card will render the whole HTML, therefore the relative logo192.png path will not be found there.

Fix

Simply added the %PUBLIC_URL% to the link component.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/plankanban/planka/pull/948 **Author:** [@knif3](https://github.com/knif3) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 11/19/2024 **Merged by:** [@meltyshev](https://github.com/meltyshev) **Base:** `master` ← **Head:** `fix/icon-path` --- ### 📝 Commits (1) - [`4200899`](https://github.com/plankanban/planka/commit/42008995ffb90bd9b750c4b996f44d40966c9d89) fix: apple-touch-icon not found ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/public/index.html` (+1 -1) </details> ### 📄 Description ## Description Opening a project page directly by its URL link causes a `404 Not Found` error for the `http://planka/boards/logo192.png` path. If we open it from the main page, this basic part is already loaded and won't re-render after navigating, but accessing a specific project or card will render the whole HTML, therefore the relative logo192.png path will not be found there. ## Fix Simply added the `%PUBLIC_URL%` to the link component. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:53:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
documentation
documentation
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/planka#1154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?