starred/planka
1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-12-06 09:13:16 +03:00
Code Issues 418 Packages Projects Releases 12 Wiki Activity

[PR #491] Add Authorization code flow with pkce and exchange the token. #1154

New Issue
Closed
opened 2025-10-09 19:09:52 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 19:09:52 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/plankanban/planka/pull/491

State: closed
Merged: Yes

uses react-oidc-context to login to an OIDC Provider and then exchanges that access token for a planka token.

I addressed, all of the concerns from this PR that I noticed. https://github.com/plankanban/planka/pull/203

  1. user table has a locked column now, though it is currently unused.
  2. password is nullable
  3. separate table to hold SSO identifiers. Will allow for multiple sign on and could be expanded to facilitate integrations
  4. exchange api that swaps the access token for one generated by planka.
  5. calls a config endpoint to get the oidc config settings

There's one big thing and a couple small thing that I know of remaining.

  1. The only place I could find to make the config settings calls was in the index.js file before the react app. While this works, it seems sketchy.
  2. Configuration to allow the text to be changed
  3. Whatever advice/suggestions to improve the situation.
**Original Pull Request:** https://github.com/plankanban/planka/pull/491 **State:** closed **Merged:** Yes --- uses react-oidc-context to login to an OIDC Provider and then exchanges that access token for a planka token. I addressed, all of the concerns from this PR that I noticed. https://github.com/plankanban/planka/pull/203 1. user table has a locked column now, though it is currently unused. 2. password is nullable 3. separate table to hold SSO identifiers. Will allow for multiple sign on and could be expanded to facilitate integrations 4. exchange api that swaps the access token for one generated by planka. 5. calls a config endpoint to get the oidc config settings There's one big thing and a couple small thing that I know of remaining. 1. The only place I could find to make the config settings calls was in the index.js file before the react app. While this works, it seems sketchy. 2. Configuration to allow the text to be changed 3. Whatever advice/suggestions to improve the situation.
OVERLORD added the pull-request label 2025-10-09 19:09:52 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
documentation
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/planka#1154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?