[PR #947] [MERGED] fix: Lazy initialize OIDC client #1149

New Issue

OVERLORD · 2026-02-04T21:53:34+03:00

OVERLORD commented

2026-02-04 21:53:34 +03:00

📋 Pull Request Information

Original PR: https://github.com/plankanban/planka/pull/947
Author: @darktohka
Created: 11/18/2024
Status: ✅ Merged
Merged: 11/19/2024
Merged by: @meltyshev

Base: master ← Head: bugfix/oidc-lazy-loading

📝 Commits (2)

88ffa08 fix: Lazy initialize OIDC client
f99fcac chore: Fix linting

📊 Changes

4 files changed (+55 additions, -20 deletions)

View changed files

📝 server/api/controllers/access-tokens/exchange-using-oidc.js (+7 -0)
📝 server/api/controllers/show-config.js (+20 -2)
📝 server/api/helpers/users/get-or-create-one-using-oidc.js (+8 -1)
📝 server/api/hooks/oidc/index.js (+20 -17)

📄 Description

Sometimes, Planka might boot before the OIDC server is ready to respond. In this case the bootup will freeze with an error:

planka-1         |2024-11-18 08:01:14 [E] Failed to lift app: Error: getaddrinfo ENOTFOUND auth.tohka.us

In this state the server is not "running", but it also does not exit, leading to a server hang.

Instead, create the client on first OIDC request (lazy loading). If the OIDC client communication fails, the server will still be running but OIDC related requests (login, configuration) will fail with a 500 Internal Server Error and a log explaining the OIDC error:

planka-1         |2024-11-18 09:06:39 [W] Error while initializing OIDC client: Error: getaddrinfo ENOTFOUND auth.tohka.us
planka-1         |2024-11-18 09:06:39 [E] Sending 500 ("Server Error") response

This ensures that users who are already logged in can continue to use Planka, and the client will be created automatically when the OIDC client starts back up again and a request to use OIDC is sent.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/plankanban/planka/pull/947 **Author:** [@darktohka](https://github.com/darktohka) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 11/19/2024 **Merged by:** [@meltyshev](https://github.com/meltyshev) **Base:** `master` ← **Head:** `bugfix/oidc-lazy-loading` --- ### 📝 Commits (2) - [`88ffa08`](https://github.com/plankanban/planka/commit/88ffa08512bbdf0bb3d3ea564fd6f5651ce66203) fix: Lazy initialize OIDC client - [`f99fcac`](https://github.com/plankanban/planka/commit/f99fcaca24439ac5f14f9fe893acb40b8bfa9c7d) chore: Fix linting ### 📊 Changes **4 files changed** (+55 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `server/api/controllers/access-tokens/exchange-using-oidc.js` (+7 -0) 📝 `server/api/controllers/show-config.js` (+20 -2) 📝 `server/api/helpers/users/get-or-create-one-using-oidc.js` (+8 -1) 📝 `server/api/hooks/oidc/index.js` (+20 -17) </details> ### 📄 Description Sometimes, Planka might boot before the OIDC server is ready to respond. In this case the bootup will freeze with an error: ``` planka-1 |2024-11-18 08:01:14 [E] Failed to lift app: Error: getaddrinfo ENOTFOUND auth.tohka.us ``` In this state the server is not "running", but it also does not exit, leading to a server hang. Instead, create the client on first OIDC request (lazy loading). If the OIDC client communication fails, the server will still be running but OIDC related requests (login, configuration) will fail with a 500 Internal Server Error and a log explaining the OIDC error: ``` planka-1 |2024-11-18 09:06:39 [W] Error while initializing OIDC client: Error: getaddrinfo ENOTFOUND auth.tohka.us planka-1 |2024-11-18 09:06:39 [E] Sending 500 ("Server Error") response ``` This ensures that users who are already logged in can continue to use Planka, and the client will be created automatically when the OIDC client starts back up again and a request to use OIDC is sent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-04 21:53:34 +03:00

OVERLORD closed this issue

2026-02-04 21:53:40 +03:00

OVERLORD referenced this issue

2026-02-04 21:56:49 +03:00

[PR #1149] [MERGED] fix: Improve dev setup #1204

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/planka#1149