[PR #885] [CLOSED] Fix to retrieve oidcEmailAttribute from tokenSet.claims() if not found in standard userInfo #1132

Closed
opened 2026-02-04 21:52:29 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/plankanban/planka/pull/885
Author: @marcomatrella
Created: 9/20/2024
Status: Closed

Base: masterHead: fix_oidc


📝 Commits (3)

  • 9290990 Fix to retrieve oidcEmailAttribute from tokenSet.claims() that converts tie idToken in array, if the oidcEmailAttribute is not found in standard userInfo
  • 080991c Removed wrong import
  • fb3a7f9 fix: Ability to configure claims source

📊 Changes

7 files changed (+46 additions, -29 deletions)

View changed files

📝 docker-compose-dev.yml (+1 -0)
📝 docker-compose.yml (+1 -0)
📝 server/.env.sample (+1 -0)
📝 server/api/controllers/access-tokens/exchange-using-oidc.js (+4 -4)
📝 server/api/helpers/users/get-or-create-one-using-oidc.js (+36 -23)
📝 server/api/helpers/utils/send-webhooks.js (+2 -2)
📝 server/config/custom.js (+1 -0)

📄 Description

Referred to bug https://github.com/plankanban/planka/issues/884


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/plankanban/planka/pull/885 **Author:** [@marcomatrella](https://github.com/marcomatrella) **Created:** 9/20/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_oidc` --- ### 📝 Commits (3) - [`9290990`](https://github.com/plankanban/planka/commit/9290990ef98917f307488daf42abbaee63d97590) Fix to retrieve oidcEmailAttribute from tokenSet.claims() that converts tie idToken in array, if the oidcEmailAttribute is not found in standard userInfo - [`080991c`](https://github.com/plankanban/planka/commit/080991c156ffd546ecbca50f5f9a09e93dd142f0) Removed wrong import - [`fb3a7f9`](https://github.com/plankanban/planka/commit/fb3a7f90395e6005ded55448f1369113ab20d756) fix: Ability to configure claims source ### 📊 Changes **7 files changed** (+46 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `docker-compose-dev.yml` (+1 -0) 📝 `docker-compose.yml` (+1 -0) 📝 `server/.env.sample` (+1 -0) 📝 `server/api/controllers/access-tokens/exchange-using-oidc.js` (+4 -4) 📝 `server/api/helpers/users/get-or-create-one-using-oidc.js` (+36 -23) 📝 `server/api/helpers/utils/send-webhooks.js` (+2 -2) 📝 `server/config/custom.js` (+1 -0) </details> ### 📄 Description Referred to bug [https://github.com/plankanban/planka/issues/884](url) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:52:29 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/planka#1132