mirror of
https://github.com/plankanban/planka.git
synced 2026-02-05 00:39:58 +03:00
[PR #876] [MERGED] feat: Change the update strategy in case of persistence #1129
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/plankanban/planka/pull/876
Author: @alineIntersec
Created: 9/13/2024
Status: ✅ Merged
Merged: 9/13/2024
Merged by: @meltyshev
Base:
master← Head:improve_deploy📝 Commits (1)
76de5f3feat: Change the update strategy in case of persistence📊 Changes
1 file changed (+4 additions, -0 deletions)
View changed files
📝
charts/planka/templates/deployment.yaml(+4 -0)📄 Description
In case planka is installed with a PV associated to the planka pod, to persist attachments and avatars for example, the default update strategy for the deployment will fail. The default "rolling update" strategy would indeed try to start a new pod before stopping the old one. But as the PV is attached to the old pod, the new pod will fail to attach and so will stay in "container creating" mode, and the old pod will never be stopped.
To avoid that, adding a condition on the deployment to use the "recreate" update strategy if the persistence is enabled. This will ensure the old pod is stopped and so the PV is detached before trying to attach the new one.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.