[PR #794] [CLOSED] fix: 🐛 clean catch possible rejected promise #1106

New Issue

OVERLORD · 2026-02-04T21:50:30+03:00

OVERLORD commented

2026-02-04 21:50:30 +03:00

📋 Pull Request Information

Original PR: https://github.com/plankanban/planka/pull/794
Author: @HannesOberreiter
Created: 6/17/2024
Status: ❌ Closed

Base: master ← Head: catch-webhook-promise

📝 Commits (1)

e94e528 fix: 🐛 nice catch possible rejected promise

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 server/api/helpers/utils/send-webhooks.js (+3 -1)

📄 Description

Improvement on catching rejected promise if the fetch API rejects, as pointed out as one possible improvement in feature request: https://github.com/plankanban/planka/issues/793

(I'm not sure if sails nicely handle/logs the rejected async event loops by themself, if so please feel free to close the pull request)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/plankanban/planka/pull/794 **Author:** [@HannesOberreiter](https://github.com/HannesOberreiter) **Created:** 6/17/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `catch-webhook-promise` --- ### 📝 Commits (1) - [`e94e528`](https://github.com/plankanban/planka/commit/e94e528c7018f10a4c4e55bda423907726ef4501) fix: :bug: nice catch possible rejected promise ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/api/helpers/utils/send-webhooks.js` (+3 -1) </details> ### 📄 Description Improvement on catching rejected promise if the fetch API rejects, as pointed out as one possible improvement in feature request: https://github.com/plankanban/planka/issues/793 (I'm not sure if sails nicely handle/logs the rejected async event loops by themself, if so please feel free to close the pull request) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-04 21:50:30 +03:00

OVERLORD closed this issue

2026-02-04 21:50:32 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/planka#1106