[PR #751] [MERGED] Enable ability for DBURI to be an existing secret #1091

New Issue

OVERLORD · 2026-02-04T21:49:33+03:00

OVERLORD commented

2026-02-04 21:49:33 +03:00

📋 Pull Request Information

Original PR: https://github.com/plankanban/planka/pull/751
Author: @justmitch123
Created: 5/10/2024
Status: ✅ Merged
Merged: 5/13/2024
Merged by: @meltyshev

Base: master ← Head: Allow_DB_URI_Secret_Helm

📝 Commits (1)

6fee0b6 Enable ability for DBURI to be an existing secret

📊 Changes

2 files changed (+16 additions, -2 deletions)

View changed files

📝 charts/planka/templates/deployment.yaml (+9 -1)
📝 charts/planka/values.yaml (+7 -1)

📄 Description

Hey,

This is hopefully a nice and simple PR. This resolves https://github.com/plankanban/planka/issues/750 by adding an existingDburlSecret field to replace the dburl if provided to securely pass the connection string into the environment.

I am not quite sure if i am happy with the naming of the variables etc in the top level but it was the closest I could come up with to match similar https://github.com/plankanban/planka/blob/master/charts/planka/values.yaml#L154 values.

I feel like it might work nicer to nest this parameter within the postgres object for consistency but either option works for my use case.

I have a helm playground here that tests out the proposed changes

Let me know if you have any question or you would like me to make any other modifications to the PR.

If these changes are approved & successful, I am keen to start moving some of the other env variables out to secrets - i.e DEFAULT_ADMIN_PASSWORD & SECRET_KEY. The main use case for this is that we will have developers that have access to view pod definitions etc, but we restrict decryption of secrets

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/plankanban/planka/pull/751 **Author:** [@justmitch123](https://github.com/justmitch123) **Created:** 5/10/2024 **Status:** ✅ Merged **Merged:** 5/13/2024 **Merged by:** [@meltyshev](https://github.com/meltyshev) **Base:** `master` ← **Head:** `Allow_DB_URI_Secret_Helm` --- ### 📝 Commits (1) - [`6fee0b6`](https://github.com/plankanban/planka/commit/6fee0b63ad567fb2e822be4138a380a232c25e97) Enable ability for DBURI to be an existing secret ### 📊 Changes **2 files changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `charts/planka/templates/deployment.yaml` (+9 -1) 📝 `charts/planka/values.yaml` (+7 -1) </details> ### 📄 Description Hey, This is hopefully a nice and simple PR. This resolves https://github.com/plankanban/planka/issues/750 by adding an `existingDburlSecret` field to replace the `dburl` if provided to securely pass the connection string into the environment. I am not quite sure if i am happy with the naming of the variables etc in the top level but it was the closest I could come up with to match similar https://github.com/plankanban/planka/blob/master/charts/planka/values.yaml#L154 values. I feel like it might work nicer to nest this parameter within the `postgres` object for consistency but either option works for my use case. I have a helm playground [here](https://helm-playground.com/#t=AQ1imB2BuBcBQYnAN4oLTAJYDNiQHsAXYAOgDUBDAGwFdwBnUgBwIaIHMAnRgR2tJRKAI2rgAJsAC%2BUxMlBpMuMlTqNBADyzsskDgBFhtLtQDK4AMY8SMufNCZIlALbhYwfQEEAKp4BCnqYAogD6AKoASgAydvag0DT0AGJcBM4IcfIMltYA0uAAnhHgOBmZ8k6u7hSJ6uBaOnqGxmY54ESx5aAA1oXuxlidSIrA4NTZ0rJdji5uHj7%2BgaGRMV0gCWruaMA8vLRYPJIARACSeEQAFuDYkBZ04hLArOzcfNTAD8zUBAWukCTaD7aERiSQFAi0fDgR5EAhPVLQLAPYCUSCjBpEXQcYDZKztG4qWpMeraTFNIwmcx4kgELgfEq6a6UDyUIgiSgTFYEgDk4gp1G5R0JaiYfJakyGYBGUEktky0vG1zl5RmVXmvgCwXC0Ul8g2yVS6V19lxeUKxVKxrilTmX1R3Uo6GenB4DH46AY0Aswl04nQFlo7DS6ED4C4VvsvQK-S4g3lGFGkFlUxV%2BFm7k1yx1a1QCeUNRFpGEHPAYRMEpz%2Brm2wL9CYxeyZfeyq60qTkyAA&v=MQUwHglgzgLhB2BzAIgIwK4CcA2BlEAxpiDAFwAEARFAPYC2JAFgogLSMjGUBQAJhjgqVc6AA6d8BLCFwxMLHqgCGUEAFVB5VNiWMAdKJ3wA1kr0F6QA) that tests out the proposed changes <img width="1524" alt="image" src="https://github.com/plankanban/planka/assets/7417605/06c54cfd-7695-4d6d-ac47-ff7c7e936ddf"> Let me know if you have any question or you would like me to make any other modifications to the PR. If these changes are approved & successful, I am keen to start moving some of the other env variables out to secrets - i.e `DEFAULT_ADMIN_PASSWORD` & `SECRET_KEY`. The main use case for this is that we will have developers that have access to view pod definitions etc, but we restrict decryption of secrets --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-04 21:49:33 +03:00

OVERLORD closed this issue

2026-02-04 21:49:34 +03:00

OVERLORD referenced this issue

2026-02-04 21:55:33 +03:00

[PR #1092] [MERGED] Add enforce_oidc_login param to /login to redirect to OIDC directly #1183

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/planka#1091