Commit Graph

22 Commits

Author SHA1 Message Date
HannesOberreiter
4124ab17d2 fix: Focus end of field when editing (#779) 2024-06-06 20:06:16 +02:00
Yu Inoue
920f9c097d fix: Display year when date is outside of current year (#567) 2023-12-20 12:26:01 +01:00
Maksim Eltyshev
239611ad51 chore: Update dependencies 2023-11-17 14:34:10 +01:00
Lorenz Brun
743f2956c8 feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2023-10-19 17:39:21 +05:00
Maksim Eltyshev
8e0c60f5be fix: OIDC finalization and refactoring 2023-10-17 19:18:19 +02:00
Maksim Eltyshev
d0a2734161 fix: Rename timer to stopwatch
Closes #392
2023-02-27 19:09:51 +01:00
Maksim Eltyshev
b0d23373c0 chore: Update dependencies 2022-11-21 00:54:05 +01:00
Maksim Eltyshev
3df07c10fa fix: Use password strength estimator
Closes #294
2022-09-03 22:47:06 +05:00
Maksim Eltyshev
62c3cca9a7 fix: Fix password length validation 2022-08-30 15:13:17 +02:00
Maksim Eltyshev
5c91bddfe7 feat: Stronger password policy 2022-08-26 18:59:44 +02:00
SimonTagne
7786533a90 feat: Improve security of access tokens (#279)
Closes #275
2022-08-09 21:03:21 +05:00
Maksim Eltyshev
3714bbc06f ref: Refactoring 2022-08-04 13:31:14 +02:00
Maksim Eltyshev
486e663a3d feat: Store accessToken in cookies instead of localStorage 2022-04-26 18:01:55 +05:00
Maksim Eltyshev
b39119ace4 Project managers, board members, auto-update after reconnection, refactoring 2021-06-24 01:05:22 +05:00
Maksim Eltyshev
0fb60eb886 Allow dots in username. Closes #116 2021-04-13 18:59:02 +05:00
Maksim Eltyshev
767d39586c Add test libs, update dependencies 2020-08-20 15:35:46 +05:00
Maksim Eltyshev
af00e3e191 Add username to user 2020-04-03 00:35:25 +05:00
Maksim Eltyshev
d1b74f9d11 Update dependencies 2020-03-25 00:15:47 +05:00
Maksim Eltyshev
9c7c96a780 Move from prettier-eslint to eslint-plugin-prettier, update dependencies 2020-02-03 18:42:31 +05:00
Maksim Eltyshev
e8139b29d5 Change id generation algorithm, display notifications total on the main page 2019-10-10 14:51:59 +05:00
Maksim Eltyshev
6eb431f721 Mute socket messages in production, fix max-len, update dependencies 2019-09-25 02:26:31 +05:00
Maksim Eltyshev
5ffef61fe7 Initial commit 2019-08-31 04:07:25 +05:00