starred/panel
1
0
Fork 0
mirror of https://github.com/pelican-dev/panel.git synced 2026-02-25 11:20:56 +03:00
Code Issues 42 Packages Projects Releases 12 Wiki Activity

[PR #699] [CLOSED] Write special env variables at the very end of the installer #910

New Issue
Closed
opened 2026-02-04 19:01:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 19:01:18 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/panel/pull/699
Author: @Boy132
Created: 11/1/2024
Status: ❌ Closed

Base: main ← Head: fix/web-installer-session-driver

📝 Commits (3)

  • 7bb86f2 write special env variables at the very end of the installer (e.g. SESSION_DRIVER)
  • 6660dd9 fix hidden check
  • a359ff3 remove cache forget from migration

📊 Changes

3 files changed (+7 additions, -8 deletions)

View changed files

📝 app/Filament/Pages/Installer/PanelInstaller.php (+4 -1)
📝 app/Filament/Pages/Installer/Steps/EnvironmentStep.php (+1 -1)
📝 database/migrations/2024_07_19_130942_create_permission_tables.php (+2 -6)

📄 Description

Closes #696

This makes sure that "special" env variables (in this case the SESSION_DRIVER) are only written to the .env file at the very end of the installer.
The SESSION_DRIVER variable is the only variable that directly affects the installer when being changed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/panel/pull/699 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 11/1/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/web-installer-session-driver` --- ### 📝 Commits (3) - [`7bb86f2`](https://github.com/pelican-dev/panel/commit/7bb86f2347aeaf459e9309996d4337930540e5ce) write special env variables at the very end of the installer (e.g. SESSION_DRIVER) - [`6660dd9`](https://github.com/pelican-dev/panel/commit/6660dd9cf6cf1aa352749da5aa15b8a02d8b1c47) fix hidden check - [`a359ff3`](https://github.com/pelican-dev/panel/commit/a359ff34c5f5c6603792ab7d27cc4a6e6aa69855) remove cache forget from migration ### 📊 Changes **3 files changed** (+7 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/Filament/Pages/Installer/PanelInstaller.php` (+4 -1) 📝 `app/Filament/Pages/Installer/Steps/EnvironmentStep.php` (+1 -1) 📝 `database/migrations/2024_07_19_130942_create_permission_tables.php` (+2 -6) </details> ### 📄 Description Closes #696 This makes sure that "special" env variables (in this case the `SESSION_DRIVER`) are only written to the .env file at the very end of the installer. The `SESSION_DRIVER` variable is the only variable that directly affects the installer when being changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 19:01:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
not confirmed
pull-request
Mirrored from GitHub Pull Request
 👑 sponsor
💰 fund
🔴 hard
🟡 medium
🟡 medium
🟡 medium
🟢 easy
🟢 easy
🟢 easy
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/panel#910
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?